Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(182)

Issue 1154213013: Stateful BoxBorderPainter (Closed)

Created:
4 years, 11 months ago by f(malita)
Modified:
4 years, 11 months ago
CC:
blink-reviews, blink-reviews-paint_chromium.org, Rik, danakj, dshwang, krit, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney, slimming-paint-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Stateful BoxBorderPainter Refactor BoxBorderPainter to rely on local state instead of hauling a gazillion arguments around. Main changes: * merge BoxBorderInfo state into BoxBorderPainter * convert all the static methods to non-static No functional changes are expected. BUG=473119 R=chrishtr@chromium.org,pdr@chromium.org,junov@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196321

Patch Set 1 #

Patch Set 2 : minor optimization #

Unified diffs Side-by-side diffs Delta from patch set Stats (+288 lines, -262 lines) Patch
M Source/core/paint/BoxBorderPainter.h View 1 chunk +46 lines, -18 lines 0 comments Download
M Source/core/paint/BoxBorderPainter.cpp View 1 15 chunks +231 lines, -242 lines 0 comments Download
M Source/core/paint/BoxPainter.cpp View 1 chunk +10 lines, -2 lines 0 comments Download
M Source/platform/geometry/FloatRoundedRect.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
f(malita)
Local Telemetry runs show no impact, while CT shows a possible tiny record time improvement ...
4 years, 11 months ago (2015-06-02 14:30:49 UTC) #2
chrishtr
lgtm
4 years, 11 months ago (2015-06-02 15:37:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1154213013/20001
4 years, 11 months ago (2015-06-02 15:38:11 UTC) #5
commit-bot: I haz the power
4 years, 11 months ago (2015-06-02 15:41:59 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196321

Powered by Google App Engine
This is Rietveld 408576698