Check for SDK error regressions on presubmit

Check for SDK error regressions on  presubmit

This is to keep us from inadvertently regressing the SDK.  See related bug #103

R=leafp@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/53a71552557ac97b61a92c99f26513677b80c110

[vsm, 2015-05-28 13:27:10]

vsm@google.com changed reviewers:
+ jmesserly@google.com, leafp@google.com

[vsm, 2015-05-28 13:28:34]

https://codereview.chromium.org/1154213008/diff/20001/tool/sdk_expected_error...
File tool/sdk_expected_errors.txt (right):

https://codereview.chromium.org/1154213008/diff/20001/tool/sdk_expected_error...
tool/sdk_expected_errors.txt:2: return zone.registerUnaryCallback(errorHandler);
We could limit this to actual errors - at least until we fix those.  That's a
much smaller list.  WDYT?

[Leaf, 2015-05-28 16:01:38]

https://codereview.chromium.org/1154213008/diff/20001/tool/build_sdk.sh
File tool/build_sdk.sh (right):

https://codereview.chromium.org/1154213008/diff/20001/tool/build_sdk.sh#newco...
tool/build_sdk.sh:16: mkdir -p test/generated_sdk/actual
What is this for?  The actual directory doesn't seem to be used by the commands
below, unless it's implicit somewhere?

https://codereview.chromium.org/1154213008/diff/20001/tool/sdk_expected_error...
File tool/sdk_expected_errors.txt (right):

https://codereview.chromium.org/1154213008/diff/20001/tool/sdk_expected_error...
tool/sdk_expected_errors.txt:2: return zone.registerUnaryCallback(errorHandler);
On 2015/05/28 13:28:33, vsm wrote:
> We could limit this to actual errors - at least until we fix those.  That's a
> much smaller list.  WDYT?

I kind of like the idea of seeing any changes, personally.  If it turns out to
be too noisy we could back off to just the errors.

[vsm, 2015-05-28 16:15:03]

PTAL

https://codereview.chromium.org/1154213008/diff/20001/tool/build_sdk.sh
File tool/build_sdk.sh (right):

https://codereview.chromium.org/1154213008/diff/20001/tool/build_sdk.sh#newco...
tool/build_sdk.sh:16: mkdir -p test/generated_sdk/actual
On 2015/05/28 16:01:38, Leaf wrote:
> What is this for?  The actual directory doesn't seem to be used by the
commands
> below, unless it's implicit somewhere?

Removed.  Vestige of previous version.  Thanks for the catch.

[Leaf, 2015-05-28 16:25:34]

lgtm

[vsm, 2015-05-28 16:26:28]

Committed patchset #3 (id:40001) manually as
53a71552557ac97b61a92c99f26513677b80c110 (presubmit successful).

[Jennifer Messerly, 2015-05-28 18:13:10]

lgtm too