Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Unified Diff: third_party/harfbuzz-ng/harfbuzz.gyp

Issue 1154213004: Revert of Fix use of 'sysroot' variable in harfbuzz.gyp (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/third_party/nss/ssl.gyp ('k') | third_party/libexif/libexif.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/harfbuzz-ng/harfbuzz.gyp
diff --git a/third_party/harfbuzz-ng/harfbuzz.gyp b/third_party/harfbuzz-ng/harfbuzz.gyp
index 8580879a8ef6273e3285613a0f3668cfd9e00f65..96e4b7c3e23abc50e3a8c59f3468dc48b60922bb 100644
--- a/third_party/harfbuzz-ng/harfbuzz.gyp
+++ b/third_party/harfbuzz-ng/harfbuzz.gyp
@@ -7,6 +7,18 @@
'../../build/win_precompile.gypi',
],
'variables': {
+ 'variables': {
+ 'conditions': [
+ ['sysroot!=""', {
+ 'pkg-config': '<(chroot_cmd) ../../build/linux/pkg-config-wrapper "<(sysroot)" "<(target_arch)" "<(system_libdir)"',
+ }, {
+ 'pkg-config': 'pkg-config'
+ }],
+ ],
+ },
+
+ 'pkg-config': '<(pkg-config)',
+
'conditions': [
['OS=="linux" and (buildtype!="Official" or chromeos==1) and embedded==0', {
# Since version 1.31.0, pangoft2 which we depend on pulls in harfbuzz
@@ -16,6 +28,12 @@
# control as well.
'use_system_harfbuzz%': '<!(python ../../build/check_return_value.py <(pkg-config) --atleast-version=1.31.0 pangoft2)',
}, {
+ 'use_system_harfbuzz': 0,
+ }],
+ ['OS=="linux" and target_arch=="arm" and chromeos==0', {
+ # Override use_system_harfbuzz for ARM cross compiling so system
+ # harfbuzz is not used because the corresponding package is not
+ # available.
'use_system_harfbuzz': 0,
}],
],
« no previous file with comments | « net/third_party/nss/ssl.gyp ('k') | third_party/libexif/libexif.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698