Issue 1154213003: RenderSector example: add a class to stack in the other direction, and fix various bugs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1154213003: RenderSector example: add a class to stack in the other direction, and fix various bugs. (Closed)

Created:
5 years, 7 months ago by Hixie

Modified:
5 years, 7 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, gregsimon, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

RenderSector example: add a class to stack in the other direction, and fix various bugs. - the circle now fills the screen - you can set dimensions on the solid color node - debugging printfs and rects are gone - the protocol is changed so that for sectors, you position before you size (since your size and your childrens' positions all depend on your own position) TBR=abarth Committed: https://chromium.googlesource.com/external/mojo/+/a4c666b35f94304ae5252d276bd115d37c16d517

Patch Set 1 #

Patch Set 2 : forgot to merge in earlier changes #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+171 lines, -45 lines)			Patch
	M	sky/examples/raw/sector-layout.dart	View	1	12 chunks	+171 lines, -45 lines	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Hixie

Committed patchset #2 (id:20001) manually as a4c666b35f94304ae5252d276bd115d37c16d517 (presubmit successful).

5 years, 7 months ago (2015-05-26 16:53:24 UTC) #1

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages