Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(48)

Issue 1154163013: Add Event::create() that takes EventInitDictionary (Closed)

Created:
4 years, 11 months ago by bashi
Modified:
4 years, 11 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add Event::create() that takes EventInitDictionary Preparing to remove EventInit. BUG=433179 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196306

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M Source/core/dom/Fullscreen.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/events/Event.h View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
bashi
PTAL?
4 years, 11 months ago (2015-06-02 07:23:44 UTC) #2
haraken
LGTM
4 years, 11 months ago (2015-06-02 08:30:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1154163013/1
4 years, 11 months ago (2015-06-02 08:43:11 UTC) #5
commit-bot: I haz the power
4 years, 11 months ago (2015-06-02 10:33:25 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196306

Powered by Google App Engine
This is Rietveld 408576698