Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(702)

Unified Diff: src/isolate.h

Issue 1154163006: Debugger: consider try-finally scopes not catching wrt debug events. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: do not specifically test turbofan Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/full-codegen.cc ('k') | src/isolate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/isolate.h
diff --git a/src/isolate.h b/src/isolate.h
index bdc3210ca2b0424c405862a45e06f64923db4196..3d00c514165ef97b91147b40f0e79b65882490c6 100644
--- a/src/isolate.h
+++ b/src/isolate.h
@@ -747,7 +747,13 @@ class Isolate {
// clause will consume or re-throw an exception. We conservatively assume any
// finally clause will behave as if the exception were consumed.
enum CatchType { NOT_CAUGHT, CAUGHT_BY_JAVASCRIPT, CAUGHT_BY_EXTERNAL };
- CatchType PredictExceptionCatcher();
+ // With the PRECISE mode, try-finally is considered to catch the exception,
+ // as the exception may or may not be rethrown. With the CONSERVATIVE mode,
+ // try-finally is considered to always rethrow. This is to meet the
+ // expectation of the debugger.
+ enum ExceptionPredictionMode { PRECISE_PREDICTION, CONSERVATIVE_PREDICTION };
+ CatchType PredictExceptionCatcher(
+ ExceptionPredictionMode prediction_mode = PRECISE_PREDICTION);
Michael Starzinger 2015/05/29 09:00:55 As discussed offline: The only reason PredictExcep
void ScheduleThrow(Object* exception);
// Re-set pending message, script and positions reported to the TryCatch
« no previous file with comments | « src/full-codegen.cc ('k') | src/isolate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698