Debugger: consider try-finally scopes not catching wrt debug events.

Debugger: consider try-finally scopes not catching wrt debug events.

R=mstarzinger@chromium.org
BUG=chromium:492522
LOG=Y

Committed: https://crrev.com/945154a27034628bde5ce2a27af7c401d635135b
Cr-Commit-Position: refs/heads/master@{#28696}

[Michael Starzinger, 2015-05-29 09:00:56]

Looking good. Just one real comment.

https://codereview.chromium.org/1154163006/diff/20001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/1154163006/diff/20001/src/objects.cc#newcode1...
src/objects.cc:11856: os << "   off      hdlr (c)\n";
nit: I tried to be smart with the "(c)" in the header here, now that the
description is in each line, let's just drop the "(c)" from the header again.

https://codereview.chromium.org/1154163006/diff/40001/src/isolate.h
File src/isolate.h (right):

https://codereview.chromium.org/1154163006/diff/40001/src/isolate.h#newcode756
src/isolate.h:756: ExceptionPredictionMode prediction_mode =
PRECISE_PREDICTION);
As discussed offline: The only reason PredictExceptionCatcher exists, is for the
debugger. So if the debugger is only ever interested in the
CONSERVATIVE_PREDICTION, then we could just make that the default and drop the
PRECISE_PREDICTION altogether. WDYT?

[Yang, 2015-05-29 09:12:27]

On 2015/05/29 09:00:56, Michael Starzinger wrote:
> Looking good. Just one real comment.
> 
> https://codereview.chromium.org/1154163006/diff/20001/src/objects.cc
> File src/objects.cc (right):
> 
>
https://codereview.chromium.org/1154163006/diff/20001/src/objects.cc#newcode1...
> src/objects.cc:11856: os << "   off      hdlr (c)\n";
> nit: I tried to be smart with the "(c)" in the header here, now that the
> description is in each line, let's just drop the "(c)" from the header again.
> 
> https://codereview.chromium.org/1154163006/diff/40001/src/isolate.h
> File src/isolate.h (right):
> 
> https://codereview.chromium.org/1154163006/diff/40001/src/isolate.h#newcode756
> src/isolate.h:756: ExceptionPredictionMode prediction_mode =
> PRECISE_PREDICTION);
> As discussed offline: The only reason PredictExceptionCatcher exists, is for
the
> debugger. So if the debugger is only ever interested in the
> CONSERVATIVE_PREDICTION, then we could just make that the default and drop the
> PRECISE_PREDICTION altogether. WDYT?

Removed mode as discussed.

[Michael Starzinger, 2015-05-29 09:18:00]

LGTM.

[Yang, 2015-05-29 09:29:48]

The CQ bit was checked by yangguo@chromium.org

[commit-bot: I haz the power, 2015-05-29 09:30:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1154163006/60001

[commit-bot: I haz the power, 2015-05-29 10:05:29]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-05-29 10:05:43]

Patchset 4 (id:??) landed as
https://crrev.com/945154a27034628bde5ce2a27af7c401d635135b
Cr-Commit-Position: refs/heads/master@{#28696}