|
Relanding 1143663007: VideoFrame: Separate Pixel Format from Storage Type.
Relanding after revert 1161803003.
(original list of reviewers:)
TBR=reveman@chromium.org, watk@chromium.org, jfroy@chromium.org, svitkine@chromium.org, DaleCurtis@chromium.org, miu@chromium.org, bbudge@chromium.org (for pepper)
Original CL description:
-----------------------------------------------------------
VideoFrame: Segregate Pixel Format and Storage Type.
VideoFrame::Format is a mix of textures and cpu-backed
formats. Textures are then further specified by
a texture format VideoFrame::TextureFormat.
This CL consolidates this into a single pixel format
and a storage type. This applies to HOLE as well,
which is understood as another Storage type.
VideoFrame ctor forces to pass a |mailbox_holders_|
also for non-texture based formats. Another private
ctor is added without this necessity, and all the
necessary factory methods are updated.
UMA-wise: Removing NATIVE_TEXTURE and HOLE from pixel
format prevents them from being UMA-accounted, but
there are no registered instances of those anyway.
NV12 format is restricted to OS_MACOSX.
BUG= 489744
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Committed: https://crrev.com/80f289fe303323361d07c5b58b23f8499903a154
Cr-Commit-Position: refs/heads/master@{#332000}
Committed: https://crrev.com/f1236fc25c67ceb18942ffc1696f24fd05e15453
Cr-Commit-Position: refs/heads/master@{#332065}
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+617 lines, -490 lines) |
Patch |
![](/static/closedtriangle.gif) |
M |
cc/layers/video_layer_impl.cc
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
cc/resources/video_resource_updater.cc
|
View
|
1
|
5 chunks |
+28 lines, -49 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
content/browser/media/capture/content_video_capture_device_core.cc
|
View
|
|
1 chunk |
+1 line, -3 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
content/browser/renderer_host/media/video_capture_buffer_pool.h
|
View
|
|
4 chunks |
+10 lines, -1 line |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
content/browser/renderer_host/media/video_capture_buffer_pool.cc
|
View
|
|
9 chunks |
+39 lines, -7 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
content/browser/renderer_host/media/video_capture_controller.cc
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
content/browser/renderer_host/media/video_capture_controller_unittest.cc
|
View
|
|
1 chunk |
+1 line, -3 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
content/browser/renderer_host/media/video_capture_device_client.cc
|
View
|
|
3 chunks |
+2 lines, -3 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
content/common/gpu/media/gpu_video_encode_accelerator.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
content/renderer/media/android/webmediaplayer_android.cc
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
content/renderer/media/rtc_video_encoder.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
content/renderer/media/video_capture_impl.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
content/renderer/media/video_track_adapter.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
content/renderer/media/webmediaplayer_ms.cc
|
View
|
|
5 chunks |
+16 lines, -18 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
content/renderer/pepper/pepper_video_encoder_host.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
media/base/mac/video_frame_mac.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
media/base/mac/video_frame_mac_unittests.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
media/base/video_decoder_config.cc
|
View
|
|
2 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
media/base/video_frame.h
|
View
|
1
|
11 chunks |
+113 lines, -60 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
media/base/video_frame.cc
|
View
|
1
|
31 chunks |
+271 lines, -207 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
media/base/video_frame_unittest.cc
|
View
|
|
3 chunks |
+7 lines, -6 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
media/blink/skcanvas_video_renderer.cc
|
View
|
1
|
10 chunks |
+35 lines, -60 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
media/blink/video_frame_compositor.cc
|
View
|
1
|
1 chunk |
+5 lines, -6 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
media/blink/webmediaplayer_impl.cc
|
View
|
|
2 chunks |
+5 lines, -8 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
media/cast/test/end2end_unittest.cc
|
View
|
|
1 chunk |
+3 lines, -2 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
media/cast/test/utility/video_utility.cc
|
View
|
|
5 chunks |
+25 lines, -20 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
media/filters/ffmpeg_video_decoder.cc
|
View
|
|
1 chunk |
+3 lines, -2 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
media/mojo/interfaces/media_types.mojom
|
View
|
|
1 chunk |
+2 lines, -3 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
media/mojo/services/media_type_converters.cc
|
View
|
|
1 chunk |
+3 lines, -6 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
media/video/gpu_memory_buffer_video_frame_pool.cc
|
View
|
1
|
1 chunk |
+9 lines, -10 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
tools/metrics/histograms/histograms.xml
|
View
|
|
4 chunks |
+23 lines, -0 lines |
0 comments
|
Download
|
Total messages: 8 (3 generated)
|