Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 1154153003: Relanding 1143663007: VideoFrame: Separate Pixel Format from Storage Type. (Closed)

Created:
5 years, 6 months ago by mcasas
Modified:
5 years, 6 months ago
Reviewers:
miu
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, posciak+watch_chromium.org, yzshen+watch_chromium.org, ben+mojo_chromium.org, miu+watch_chromium.org, jam, abarth-chromium, hguihot+watch_chromium.org, darin-cc_chromium.org, hubbe+watch_chromium.org, mlamouri+watch-content_chromium.org, imcheng+watch_chromium.org, jasonroberts+watch_google.com, feature-media-reviews_chromium.org, asvitkine+watch_chromium.org, piman+watch_chromium.org, darin (slow to review), hclam+watch_chromium.org, avayvod+watch_chromium.org, mcasas+watch_chromium.org, Aaron Boodman, mkwst+moarreviews-renderer_chromium.org, cc-bugs_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Relanding 1143663007: VideoFrame: Separate Pixel Format from Storage Type. Relanding after revert 1161803003. (original list of reviewers:) TBR=reveman@chromium.org, watk@chromium.org, jfroy@chromium.org, svitkine@chromium.org, DaleCurtis@chromium.org, miu@chromium.org, bbudge@chromium.org (for pepper) Original CL description: ----------------------------------------------------------- VideoFrame: Segregate Pixel Format and Storage Type. VideoFrame::Format is a mix of textures and cpu-backed formats. Textures are then further specified by a texture format VideoFrame::TextureFormat. This CL consolidates this into a single pixel format and a storage type. This applies to HOLE as well, which is understood as another Storage type. VideoFrame ctor forces to pass a |mailbox_holders_| also for non-texture based formats. Another private ctor is added without this necessity, and all the necessary factory methods are updated. UMA-wise: Removing NATIVE_TEXTURE and HOLE from pixel format prevents them from being UMA-accounted, but there are no registered instances of those anyway. NV12 format is restricted to OS_MACOSX. BUG=489744 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/80f289fe303323361d07c5b58b23f8499903a154 Cr-Commit-Position: refs/heads/master@{#332000} Committed: https://crrev.com/f1236fc25c67ceb18942ffc1696f24fd05e15453 Cr-Commit-Position: refs/heads/master@{#332065}

Patch Set 1 #

Patch Set 2 : Added NV12 support in CrOS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+617 lines, -490 lines) Patch
M cc/layers/video_layer_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/resources/video_resource_updater.cc View 1 5 chunks +28 lines, -49 lines 0 comments Download
M content/browser/media/capture/content_video_capture_device_core.cc View 1 chunk +1 line, -3 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_buffer_pool.h View 4 chunks +10 lines, -1 line 0 comments Download
M content/browser/renderer_host/media/video_capture_buffer_pool.cc View 9 chunks +39 lines, -7 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_controller_unittest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_device_client.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M content/common/gpu/media/gpu_video_encode_accelerator.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/android/webmediaplayer_android.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/media/rtc_video_encoder.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/video_capture_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/video_track_adapter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webmediaplayer_ms.cc View 5 chunks +16 lines, -18 lines 0 comments Download
M content/renderer/pepper/pepper_video_encoder_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/mac/video_frame_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/mac/video_frame_mac_unittests.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/video_decoder_config.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M media/base/video_frame.h View 1 11 chunks +113 lines, -60 lines 0 comments Download
M media/base/video_frame.cc View 1 31 chunks +271 lines, -207 lines 0 comments Download
M media/base/video_frame_unittest.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M media/blink/skcanvas_video_renderer.cc View 1 10 chunks +35 lines, -60 lines 0 comments Download
M media/blink/video_frame_compositor.cc View 1 1 chunk +5 lines, -6 lines 0 comments Download
M media/blink/webmediaplayer_impl.cc View 2 chunks +5 lines, -8 lines 0 comments Download
M media/cast/test/end2end_unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M media/cast/test/utility/video_utility.cc View 5 chunks +25 lines, -20 lines 0 comments Download
M media/filters/ffmpeg_video_decoder.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M media/mojo/interfaces/media_types.mojom View 1 chunk +2 lines, -3 lines 0 comments Download
M media/mojo/services/media_type_converters.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M media/video/gpu_memory_buffer_video_frame_pool.cc View 1 1 chunk +9 lines, -10 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 4 chunks +23 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1154153003/20001
5 years, 6 months ago (2015-05-29 21:03:53 UTC) #3
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-05-29 22:39:10 UTC) #4
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/f1236fc25c67ceb18942ffc1696f24fd05e15453 Cr-Commit-Position: refs/heads/master@{#332065}
5 years, 6 months ago (2015-05-29 22:39:59 UTC) #5
miu
Well, this solves the debate we had over having the NV12 format. ;-)
5 years, 6 months ago (2015-05-29 22:42:30 UTC) #6
miu
5 years, 6 months ago (2015-05-29 22:42:39 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698