Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 1154133003: [Startup Tracing] Separate TraceOptions and CategoryFilter (Closed)

Created:
5 years, 7 months ago by Zhen Wang
Modified:
5 years, 7 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, tracing+reviews_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Startup Tracing] Separate TraceOptions and CategoryFilter This CL moves CategoryFilter and TraceOptions to their own files. This is the first step to replace CategoryFilter and TraceOptions by a unified TraceConfig class. There are three steps. 1- Move current CategoryFilter and TraceOptions to new file. 2- Create TraceConfig but don't use it anywhere 3- Hookup TraceConfig and remove CategoryFilter and TraceOptions. Background: Implementing TraceConfig is the first stage for startup tracing. Startup tracing design doc: https://docs.google.com/document/d/1yRCXhrQ-0rsfUgNHt9T4YdnmJYrXKN6aK56Ozk3kPVc/edit?usp=sharing TraceConfig class design doc: https://docs.google.com/document/d/1zwc6FdeYyrC7m9fC4jJqbkqpB0il9NV-MWH7lEnL0cc/edit?usp=sharing trace-config file format doc: https://docs.google.com/document/d/1auY0Buk-R2tGCzpHJzFgyTfngXTAK0mlxJc6J4M_CK4/edit?usp=sharing BUG=317481, 482098 Committed: https://crrev.com/daaba16762de04f5fdf16b510409e1eabb122e6e Cr-Commit-Position: refs/heads/master@{#331386}

Patch Set 1 #

Patch Set 2 : add gn build support #

Unified diffs Side-by-side diffs Delta from patch set Stats (+732 lines, -625 lines) Patch
M base/trace_event/BUILD.gn View 1 4 chunks +6 lines, -0 lines 0 comments Download
A base/trace_event/category_filter.h View 1 chunk +107 lines, -0 lines 0 comments Download
A base/trace_event/category_filter.cc View 1 chunk +247 lines, -0 lines 0 comments Download
A base/trace_event/category_filter_unittest.cc View 1 chunk +111 lines, -0 lines 0 comments Download
M base/trace_event/trace_event.gypi View 4 chunks +6 lines, -0 lines 0 comments Download
M base/trace_event/trace_event_impl.h View 2 chunks +2 lines, -148 lines 0 comments Download
M base/trace_event/trace_event_impl.cc View 4 chunks +0 lines, -300 lines 0 comments Download
M base/trace_event/trace_event_unittest.cc View 2 chunks +0 lines, -177 lines 0 comments Download
A base/trace_event/trace_options.h View 1 chunk +79 lines, -0 lines 0 comments Download
A base/trace_event/trace_options.cc View 1 chunk +84 lines, -0 lines 0 comments Download
A base/trace_event/trace_options_unittest.cc View 1 chunk +90 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Zhen Wang
ptal By the way, do you know why some trybots failed? It compiles fine on ...
5 years, 7 months ago (2015-05-26 03:43:24 UTC) #2
dsinclair
lgtm. It looks like all the failed compiles are using the GN scripts. Can you ...
5 years, 7 months ago (2015-05-26 13:41:21 UTC) #3
Zhen Wang
On 2015/05/26 13:41:21, dsinclair wrote: > lgtm. > > It looks like all the failed ...
5 years, 7 months ago (2015-05-26 15:31:39 UTC) #4
dsinclair
lgtm
5 years, 7 months ago (2015-05-26 15:32:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1154133003/20001
5 years, 7 months ago (2015-05-26 15:34:18 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-26 17:26:02 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-26 17:27:30 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/daaba16762de04f5fdf16b510409e1eabb122e6e
Cr-Commit-Position: refs/heads/master@{#331386}

Powered by Google App Engine
This is Rietveld 408576698