Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 1154113007: Use ApplicationRunner for consistency in CoreServices. (Closed)

Created:
5 years, 6 months ago by jam
Modified:
5 years, 6 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use ApplicationRunner for consistency in CoreServices. This way apps can make assumptions about orders of destruction of message loop, delegate, applicationimpl and it works the same across all apps. Committed: https://crrev.com/cd7c64859aba1c58428fe4d4c3eeb16aeb335dcd Cr-Commit-Position: refs/heads/master@{#333089}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -72 lines) Patch
M mandoline/services/core_services/core_services_application_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M mandoline/services/core_services/core_services_application_delegate.cc View 5 chunks +20 lines, -71 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
jam
5 years, 6 months ago (2015-06-05 15:18:57 UTC) #4
Elliot Glaysher
lgtm
5 years, 6 months ago (2015-06-05 17:07:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1154113007/40001
5 years, 6 months ago (2015-06-05 17:40:01 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:40001)
5 years, 6 months ago (2015-06-05 17:53:08 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 18:03:44 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cd7c64859aba1c58428fe4d4c3eeb16aeb335dcd
Cr-Commit-Position: refs/heads/master@{#333089}

Powered by Google App Engine
This is Rietveld 408576698