Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: src/arm64/full-codegen-arm64.cc

Issue 1154103005: Refactor lexical home object binding (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: git rebase Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/arm/full-codegen-arm.cc ('k') | src/ast.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/arm64/full-codegen-arm64.cc
diff --git a/src/arm64/full-codegen-arm64.cc b/src/arm64/full-codegen-arm64.cc
index 507ce3dab8c9dda37b4ad7e213b9bd72f2155b6b..42254d6271d0783fbe771d444ad6f67b4224d6b9 100644
--- a/src/arm64/full-codegen-arm64.cc
+++ b/src/arm64/full-codegen-arm64.cc
@@ -243,11 +243,6 @@ void FullCodeGenerator::Generate() {
}
}
- Variable* home_object_var = scope()->home_object_var();
- if (home_object_var != nullptr) {
- __ Push(x1);
- }
-
// Possibly set up a local binding to the this function which is used in
// derived constructors with super calls.
Variable* this_function_var = scope()->this_function_var();
@@ -331,19 +326,6 @@ void FullCodeGenerator::Generate() {
SetVar(arguments, x0, x1, x2);
}
- // Possibly set up a local binding to the [[HomeObject]].
- if (home_object_var != nullptr) {
- Comment cmnt(masm_, "[ Home object");
- __ Pop(LoadDescriptor::ReceiverRegister());
- Handle<Symbol> home_object_symbol(isolate()->heap()->home_object_symbol());
- __ Mov(LoadDescriptor::NameRegister(), home_object_symbol);
- __ Mov(LoadDescriptor::SlotRegister(),
- SmiFromSlot(function()->HomeObjectFeedbackSlot()));
- CallLoadIC(NOT_CONTEXTUAL);
-
- SetVar(home_object_var, x0, x1, x2);
- }
-
if (FLAG_trace) {
__ CallRuntime(Runtime::kTraceEnter, 0);
}
@@ -1991,7 +1973,7 @@ void FullCodeGenerator::VisitAssignment(Assignment* expr) {
VisitForStackValue(
property->obj()->AsSuperPropertyReference()->this_var());
VisitForAccumulatorValue(
- property->obj()->AsSuperPropertyReference()->home_object_var());
+ property->obj()->AsSuperPropertyReference()->home_object());
__ Push(result_register());
if (expr->is_compound()) {
const Register scratch = x10;
@@ -2003,7 +1985,7 @@ void FullCodeGenerator::VisitAssignment(Assignment* expr) {
VisitForStackValue(
property->obj()->AsSuperPropertyReference()->this_var());
VisitForStackValue(
- property->obj()->AsSuperPropertyReference()->home_object_var());
+ property->obj()->AsSuperPropertyReference()->home_object());
VisitForAccumulatorValue(property->key());
__ Push(result_register());
if (expr->is_compound()) {
@@ -2362,7 +2344,7 @@ void FullCodeGenerator::EmitAssignment(Expression* expr,
__ Push(x0);
VisitForStackValue(prop->obj()->AsSuperPropertyReference()->this_var());
VisitForAccumulatorValue(
- prop->obj()->AsSuperPropertyReference()->home_object_var());
+ prop->obj()->AsSuperPropertyReference()->home_object());
// stack: value, this; x0: home_object
Register scratch = x10;
Register scratch2 = x11;
@@ -2379,7 +2361,7 @@ void FullCodeGenerator::EmitAssignment(Expression* expr,
__ Push(x0);
VisitForStackValue(prop->obj()->AsSuperPropertyReference()->this_var());
VisitForStackValue(
- prop->obj()->AsSuperPropertyReference()->home_object_var());
+ prop->obj()->AsSuperPropertyReference()->home_object());
VisitForAccumulatorValue(prop->key());
Register scratch = x10;
Register scratch2 = x11;
@@ -2607,7 +2589,7 @@ void FullCodeGenerator::VisitProperty(Property* expr) {
} else {
VisitForStackValue(expr->obj()->AsSuperPropertyReference()->this_var());
VisitForStackValue(
- expr->obj()->AsSuperPropertyReference()->home_object_var());
+ expr->obj()->AsSuperPropertyReference()->home_object());
EmitNamedSuperPropertyLoad(expr);
}
} else {
@@ -2620,7 +2602,7 @@ void FullCodeGenerator::VisitProperty(Property* expr) {
} else {
VisitForStackValue(expr->obj()->AsSuperPropertyReference()->this_var());
VisitForStackValue(
- expr->obj()->AsSuperPropertyReference()->home_object_var());
+ expr->obj()->AsSuperPropertyReference()->home_object());
VisitForStackValue(expr->key());
EmitKeyedSuperPropertyLoad(expr);
}
@@ -2690,7 +2672,7 @@ void FullCodeGenerator::EmitSuperCallWithLoadIC(Call* expr) {
const Register scratch = x10;
SuperPropertyReference* super_ref =
callee->AsProperty()->obj()->AsSuperPropertyReference();
- VisitForStackValue(super_ref->home_object_var());
+ VisitForStackValue(super_ref->home_object());
VisitForAccumulatorValue(super_ref->this_var());
__ Push(x0);
__ Peek(scratch, kPointerSize);
@@ -2750,7 +2732,7 @@ void FullCodeGenerator::EmitKeyedSuperCallWithLoadIC(Call* expr) {
const Register scratch = x10;
SuperPropertyReference* super_ref =
callee->AsProperty()->obj()->AsSuperPropertyReference();
- VisitForStackValue(super_ref->home_object_var());
+ VisitForStackValue(super_ref->home_object());
VisitForAccumulatorValue(super_ref->this_var());
__ Push(x0);
__ Peek(scratch, kPointerSize);
@@ -4604,7 +4586,7 @@ void FullCodeGenerator::VisitCountOperation(CountOperation* expr) {
case NAMED_SUPER_PROPERTY: {
VisitForStackValue(prop->obj()->AsSuperPropertyReference()->this_var());
VisitForAccumulatorValue(
- prop->obj()->AsSuperPropertyReference()->home_object_var());
+ prop->obj()->AsSuperPropertyReference()->home_object());
__ Push(result_register());
const Register scratch = x10;
__ Peek(scratch, kPointerSize);
@@ -4616,7 +4598,7 @@ void FullCodeGenerator::VisitCountOperation(CountOperation* expr) {
case KEYED_SUPER_PROPERTY: {
VisitForStackValue(prop->obj()->AsSuperPropertyReference()->this_var());
VisitForStackValue(
- prop->obj()->AsSuperPropertyReference()->home_object_var());
+ prop->obj()->AsSuperPropertyReference()->home_object());
VisitForAccumulatorValue(prop->key());
__ Push(result_register());
const Register scratch1 = x10;
« no previous file with comments | « src/arm/full-codegen-arm.cc ('k') | src/ast.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698