Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: sdk/lib/_internal/compiler/js_lib/js_mirrors.dart

Issue 1154073004: Change more JS foreign methods to JS_GET_NAME. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/js_lib/js_mirrors.dart
diff --git a/sdk/lib/_internal/compiler/js_lib/js_mirrors.dart b/sdk/lib/_internal/compiler/js_lib/js_mirrors.dart
index ff7e9c509ae724e7ca4ffbb3bd9c019a2fa627b8..ff0fd3ab9a10b727fb5369338d2efce66db12c80 100644
--- a/sdk/lib/_internal/compiler/js_lib/js_mirrors.dart
+++ b/sdk/lib/_internal/compiler/js_lib/js_mirrors.dart
@@ -2631,41 +2631,41 @@ class JsFunctionTypeMirror extends BrokenClassMirror
JsFunctionTypeMirror(this._typeData, this.owner);
bool get _hasReturnType {
- return JS('bool', '# in #', JS_FUNCTION_TYPE_RETURN_TYPE_TAG(), _typeData);
+ return JS('bool', '# in #', JS_GET_NAME(JsGetName.FUNCTION_TYPE_RETURN_TYPE_TAG), _typeData);
herhut 2015/06/03 08:58:28 Long line...
}
get _returnType {
- return JS('', '#[#]', _typeData, JS_FUNCTION_TYPE_RETURN_TYPE_TAG());
+ return JS('', '#[#]', _typeData, JS_GET_NAME(JsGetName.FUNCTION_TYPE_RETURN_TYPE_TAG));
herhut 2015/06/03 08:58:28 Long line...
}
bool get _isVoid {
- return JS('bool', '!!#[#]', _typeData, JS_FUNCTION_TYPE_VOID_RETURN_TAG());
+ return JS('bool', '!!#[#]', _typeData, JS_GET_NAME(JsGetName.FUNCTION_TYPE_VOID_RETURN_TAG));
herhut 2015/06/03 08:58:28 Long line...
}
bool get _hasArguments {
return JS('bool', '# in #',
- JS_FUNCTION_TYPE_REQUIRED_PARAMETERS_TAG(), _typeData);
+ JS_GET_NAME(JsGetName.FUNCTION_TYPE_REQUIRED_PARAMETERS_TAG), _typeData);
herhut 2015/06/03 08:58:28 Long line...
}
List get _arguments {
return JS('JSExtendableArray', '#[#]',
- _typeData, JS_FUNCTION_TYPE_REQUIRED_PARAMETERS_TAG());
+ _typeData, JS_GET_NAME(JsGetName.FUNCTION_TYPE_REQUIRED_PARAMETERS_TAG));
herhut 2015/06/03 08:58:28 Long line...
}
bool get _hasOptionalArguments {
return JS('bool', '# in #',
- JS_FUNCTION_TYPE_OPTIONAL_PARAMETERS_TAG(), _typeData);
+ JS_GET_NAME(JsGetName.FUNCTION_TYPE_OPTIONAL_PARAMETERS_TAG), _typeData);
herhut 2015/06/03 08:58:28 Long line...
}
List get _optionalArguments {
return JS('JSExtendableArray', '#[#]',
- _typeData, JS_FUNCTION_TYPE_OPTIONAL_PARAMETERS_TAG());
+ _typeData, JS_GET_NAME(JsGetName.FUNCTION_TYPE_OPTIONAL_PARAMETERS_TAG));
herhut 2015/06/03 08:58:28 Long line...
}
bool get _hasNamedArguments {
return JS('bool', '# in #',
herhut 2015/06/03 08:58:28 Long line...
- JS_FUNCTION_TYPE_NAMED_PARAMETERS_TAG(), _typeData);
+ JS_GET_NAME(JsGetName.FUNCTION_TYPE_NAMED_PARAMETERS_TAG), _typeData);
}
get _namedArguments {
return JS('=Object', '#[#]',
- _typeData, JS_FUNCTION_TYPE_NAMED_PARAMETERS_TAG());
+ _typeData, JS_GET_NAME(JsGetName.FUNCTION_TYPE_NAMED_PARAMETERS_TAG));
herhut 2015/06/03 08:58:28 Long line...
}
bool get isOriginalDeclaration => true;
@@ -2854,7 +2854,7 @@ TypeMirror typeMirrorFromRuntimeTypeRepresentation(
return reflectClassByMangledName(
getMangledTypeName(createRuntimeType(representation)));
}
- String typedefPropertyName = JS_TYPEDEF_TAG();
+ String typedefPropertyName = JS_GET_NAME(JsGetName.TYPEDEF_TAG);
if (type != null && JS('', '#[#]', type, typedefPropertyName) != null) {
return typeMirrorFromRuntimeTypeRepresentation(
owner, JS('', '#[#]', type, typedefPropertyName));

Powered by Google App Engine
This is Rietveld 408576698