Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(624)

Unified Diff: pkg/compiler/lib/src/ssa/builder.dart

Issue 1154073004: Change more JS foreign methods to JS_GET_NAME. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/ssa/builder.dart
diff --git a/pkg/compiler/lib/src/ssa/builder.dart b/pkg/compiler/lib/src/ssa/builder.dart
index 331c75047831e15448a3896e395374a930ca252f..abc4e043cda7c85b2fe5e2e894e5878a5aba4d79 100644
--- a/pkg/compiler/lib/src/ssa/builder.dart
+++ b/pkg/compiler/lib/src/ssa/builder.dart
@@ -4258,36 +4258,6 @@ class SsaBuilder extends NewResolvedVisitor {
handleForeignRawFunctionRef(node, 'RAW_DART_FUNCTION_REF');
} else if (name == 'JS_SET_CURRENT_ISOLATE') {
handleForeignSetCurrentIsolate(node);
- } else if (name == 'JS_OPERATOR_AS_PREFIX') {
- // TODO(floitsch): this should be a JS_NAME.
- stack.add(addConstantString(backend.namer.operatorAsPrefix));
- } else if (name == 'JS_SIGNATURE_NAME') {
- // TODO(floitsch): this should be a JS_NAME.
- stack.add(addConstantString(backend.namer.operatorSignature));
- } else if (name == 'JS_TYPEDEF_TAG') {
- // TODO(floitsch): this should be a JS_NAME.
- stack.add(addConstantString(backend.namer.typedefTag));
- } else if (name == 'JS_FUNCTION_TYPE_VOID_RETURN_TAG') {
- // TODO(floitsch): this should be a JS_NAME.
- stack.add(addConstantString(backend.namer.functionTypeVoidReturnTag));
- } else if (name == 'JS_FUNCTION_TYPE_RETURN_TYPE_TAG') {
- // TODO(floitsch): this should be a JS_NAME.
- stack.add(addConstantString(backend.namer.functionTypeReturnTypeTag));
- } else if (name ==
- 'JS_FUNCTION_TYPE_REQUIRED_PARAMETERS_TAG') {
- // TODO(floitsch): this should be a JS_NAME.
- stack.add(addConstantString(
- backend.namer.functionTypeRequiredParametersTag));
- } else if (name ==
- 'JS_FUNCTION_TYPE_OPTIONAL_PARAMETERS_TAG') {
- // TODO(floitsch): this should be a JS_NAME.
- stack.add(addConstantString(
- backend.namer.functionTypeOptionalParametersTag));
- } else if (name ==
- 'JS_FUNCTION_TYPE_NAMED_PARAMETERS_TAG') {
- // TODO(floitsch): this should be a JS_NAME.
- stack.add(addConstantString(
- backend.namer.functionTypeNamedParametersTag));
} else if (name == 'JS_IS_INDEXABLE_FIELD_NAME') {
// TODO(floitsch): this should be a JS_NAME.
Element element = backend.findHelper('JavaScriptIndexingBehavior');
@@ -4309,7 +4279,7 @@ class SsaBuilder extends NewResolvedVisitor {
} else if (name == 'JS_STRING_CONCAT') {
handleJsStringConcat(node);
} else {
- throw "Unknown foreign: ${element}";
+ compiler.internalError(node, "Unknown foreign: ${element}");
}
}

Powered by Google App Engine
This is Rietveld 408576698