Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/metrics/proto/omnibox_event.proto

Issue 1154063003: removing ShouldHideTopMatch (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed ShouldHideTopVerbatim code Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/ui/omnibox/omnibox_controller.cc ('K') | « chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc ('k') | components/omnibox/autocomplete_result.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/metrics/proto/omnibox_event.proto
diff --git a/components/metrics/proto/omnibox_event.proto b/components/metrics/proto/omnibox_event.proto
index b3e6656344a1e180e94ee92726a9f79fba17123a..6980355ced14a3245e10b8bfc25b6d60b29136bd 100644
--- a/components/metrics/proto/omnibox_event.proto
+++ b/components/metrics/proto/omnibox_event.proto
@@ -39,9 +39,9 @@ message OmniboxEventProto {
// This corresponds the index of the |suggestion| below.
optional int32 selected_index = 5;
- // Whether or not the top match was hidden in the omnibox suggestions
- // dropdown.
- optional bool is_top_result_hidden_in_dropdown = 14;
+ // DEPRECATED. Whether or not the top match was hidden in the omnibox
+ // suggestions dropdown.
+ optional bool is_top_result_hidden_in_dropdown = 14 [deprecated=true];
// Whether the omnibox popup is open. It can be closed if, for instance,
// the user clicks in the omnibox and hits return to reload the same page.
« chrome/browser/ui/omnibox/omnibox_controller.cc ('K') | « chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc ('k') | components/omnibox/autocomplete_result.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698