Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Side by Side Diff: components/metrics/proto/omnibox_event.proto

Issue 1154063003: removing ShouldHideTopMatch (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comment change in GetMatchToPrefetch Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Stores information about an omnibox interaction. 5 // Stores information about an omnibox interaction.
6 6
7 syntax = "proto2"; 7 syntax = "proto2";
8 8
9 option optimize_for = LITE_RUNTIME; 9 option optimize_for = LITE_RUNTIME;
10 option java_outer_classname = "OmniboxEventProtos"; 10 option java_outer_classname = "OmniboxEventProtos";
(...skipping 21 matching lines...) Expand all
32 // suggestion. This is usually the result of pressing backspace or delete. 32 // suggestion. This is usually the result of pressing backspace or delete.
33 optional bool just_deleted_text = 11; 33 optional bool just_deleted_text = 11;
34 34
35 // The number of terms that the user typed in the omnibox. 35 // The number of terms that the user typed in the omnibox.
36 optional int32 num_typed_terms = 4; 36 optional int32 num_typed_terms = 4;
37 37
38 // The index of the item that the user selected in the omnibox popup list. 38 // The index of the item that the user selected in the omnibox popup list.
39 // This corresponds the index of the |suggestion| below. 39 // This corresponds the index of the |suggestion| below.
40 optional int32 selected_index = 5; 40 optional int32 selected_index = 5;
41 41
42 // Whether or not the top match was hidden in the omnibox suggestions 42 // DEPRECATED. Whether or not the top match was hidden in the omnibox
43 // dropdown. 43 // suggestions dropdown.
44 optional bool is_top_result_hidden_in_dropdown = 14; 44 optional bool is_top_result_hidden_in_dropdown = 14 [deprecated = true];
Mark P 2015/06/10 04:26:18 Given that changed the name of the field internall
dschuyler 2015/06/10 18:29:33 Done.
45 45
46 // Whether the omnibox popup is open. It can be closed if, for instance, 46 // Whether the omnibox popup is open. It can be closed if, for instance,
47 // the user clicks in the omnibox and hits return to reload the same page. 47 // the user clicks in the omnibox and hits return to reload the same page.
48 // If the popup is closed, the suggestion list will contain only one item 48 // If the popup is closed, the suggestion list will contain only one item
49 // and selected_index will be 0 (pointing to that single item). Because 49 // and selected_index will be 0 (pointing to that single item). Because
50 // paste-and-search/paste-and-go actions ignore the current content of the 50 // paste-and-search/paste-and-go actions ignore the current content of the
51 // omnibox dropdown (if it is open) when they happen, we pretend the 51 // omnibox dropdown (if it is open) when they happen, we pretend the
52 // dropdown is closed when logging these. 52 // dropdown is closed when logging these.
53 optional bool is_popup_open = 15; 53 optional bool is_popup_open = 15;
54 54
(...skipping 219 matching lines...) Expand 10 before | Expand all | Expand 10 after
274 // The number of times this provider returned a non-zero number of 274 // The number of times this provider returned a non-zero number of
275 // suggestions during this omnibox session. 275 // suggestions during this omnibox session.
276 // Note that each provider may define a session differently for its 276 // Note that each provider may define a session differently for its
277 // purposes. 277 // purposes.
278 optional int32 times_returned_results_in_session = 5; 278 optional int32 times_returned_results_in_session = 5;
279 } 279 }
280 // A list of diagnostic information about each provider. Providers 280 // A list of diagnostic information about each provider. Providers
281 // will appear at most once in this list. 281 // will appear at most once in this list.
282 repeated ProviderInfo provider_info = 12; 282 repeated ProviderInfo provider_info = 12;
283 } 283 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc ('k') | components/omnibox/autocomplete_result.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698