[Chromoting] Fix os detection logic in logs.

Cause:
From the user agent strings in our server logs, the offending user agents are
    Morzilla/5.0 (X11; CrOS x86_64 6457.107.0)
which fails to match
   'CrOS ([a-zA-Z0-9]*) ([0-9.]*)'
because _ is missing in the first match group.

This CL:
1. Fixes the regular expression.
2. Unifies the duplicated platform detection logic in our logs and platform.js
3. Implements an unit test using key examples from the server logs as test cases.

BUG=495206
Committed: https://crrev.com/e989257af8a63fa4e5780635259b04663247ab5b
Cr-Commit-Position: refs/heads/master@{#333208}

[kelvinp, 2015-06-06 00:47:57]

kelvinp@chromium.org changed reviewers:
+ jamiewalch@chromium.org

[kelvinp, 2015-06-06 00:48:47]

PTAL

https://codereview.chromium.org/1154023007/diff/1/remoting/webapp/base/js/pla...
File remoting/webapp/base/js/platform.js (right):

https://codereview.chromium.org/1154023007/diff/1/remoting/webapp/base/js/pla...
remoting/webapp/base/js/platform.js:78: remoting.getSystemInfo = function() {
mainly copied from remoting.ServerLogEntry.extractHostData_

[Jamie, 2015-06-06 01:05:41]

LGTM with naming nits.

https://codereview.chromium.org/1154023007/diff/1/remoting/webapp/base/js/pla...
File remoting/webapp/base/js/platform.js (right):

https://codereview.chromium.org/1154023007/diff/1/remoting/webapp/base/js/pla...
remoting/webapp/base/js/platform.js:24: *  chrome_version: string
I realize this is mostly copy/paste, but you might as well update these to use
JS naming convention (osName, osVersion, etc.)

https://codereview.chromium.org/1154023007/diff/1/remoting/webapp/base/js/pla...
File remoting/webapp/base/js/platform_unittest.js (right):

https://codereview.chromium.org/1154023007/diff/1/remoting/webapp/base/js/pla...
remoting/webapp/base/js/platform_unittest.js:98: function forEachTest(/**
function(Object<string>, string) */ callback) {
This should be called something like "forEachUserAgent", since "test" in the
context of this file refers to Qunit.test.

https://codereview.chromium.org/1154023007/diff/1/remoting/webapp/base/js/ser...
File remoting/webapp/base/js/server_log_entry.js (right):

https://codereview.chromium.org/1154023007/diff/1/remoting/webapp/base/js/ser...
remoting/webapp/base/js/server_log_entry.js:372: var host =
remoting.getSystemInfo();
This is a confusing name, given that the containing method refers to "client". I
suggest just calling it systemInfo.

[kelvinp, 2015-06-06 02:09:47]

The CQ bit was checked by kelvinp@chromium.org

[kelvinp, 2015-06-06 02:09:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamiewalch@chromium.org
Link to the patchset: https://codereview.chromium.org/1154023007/#ps20001
(title: "Reviewer's feedback")

[kelvinp, 2015-06-06 02:09:55]

FYI

https://codereview.chromium.org/1154023007/diff/1/remoting/webapp/base/js/pla...
File remoting/webapp/base/js/platform.js (right):

https://codereview.chromium.org/1154023007/diff/1/remoting/webapp/base/js/pla...
remoting/webapp/base/js/platform.js:24: *  chrome_version: string
On 2015/06/06 01:05:41, Jamie wrote:
> I realize this is mostly copy/paste, but you might as well update these to use
> JS naming convention (osName, osVersion, etc.)

Done.

https://codereview.chromium.org/1154023007/diff/1/remoting/webapp/base/js/pla...
File remoting/webapp/base/js/platform_unittest.js (right):

https://codereview.chromium.org/1154023007/diff/1/remoting/webapp/base/js/pla...
remoting/webapp/base/js/platform_unittest.js:98: function forEachTest(/**
function(Object<string>, string) */ callback) {
On 2015/06/06 01:05:41, Jamie wrote:
> This should be called something like "forEachUserAgent", since "test" in the
> context of this file refers to Qunit.test.

Done.

https://codereview.chromium.org/1154023007/diff/1/remoting/webapp/base/js/ser...
File remoting/webapp/base/js/server_log_entry.js (right):

https://codereview.chromium.org/1154023007/diff/1/remoting/webapp/base/js/ser...
remoting/webapp/base/js/server_log_entry.js:372: var host =
remoting.getSystemInfo();
On 2015/06/06 01:05:41, Jamie wrote:
> This is a confusing name, given that the containing method refers to "client".
I
> suggest just calling it systemInfo.

Done.

[commit-bot: I haz the power, 2015-06-06 02:10:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1154023007/20001

[commit-bot: I haz the power, 2015-06-06 02:56:52]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-06-06 02:58:31]

Patchset 2 (id:??) landed as
https://crrev.com/e989257af8a63fa4e5780635259b04663247ab5b
Cr-Commit-Position: refs/heads/master@{#333208}