Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Unified Diff: chrome/browser/ui/cocoa/base_bubble_controller_unittest.mm

Issue 1154013009: [OSX] Don't create deferred windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/base_bubble_controller_unittest.mm
diff --git a/chrome/browser/ui/cocoa/base_bubble_controller_unittest.mm b/chrome/browser/ui/cocoa/base_bubble_controller_unittest.mm
index fd2d5adb09112dc9bed4ef90d98e774ee932084f..42d74c808edc838819f4f35adaef9e11cf8882d5 100644
--- a/chrome/browser/ui/cocoa/base_bubble_controller_unittest.mm
+++ b/chrome/browser/ui/cocoa/base_bubble_controller_unittest.mm
@@ -94,7 +94,7 @@ class BaseBubbleControllerTest : public CocoaTest {
kBubbleWindowHeight)
styleMask:NSBorderlessWindowMask
backing:NSBackingStoreBuffered
- defer:YES]);
+ defer:NO]);
[bubble_window_ setAllowedAnimations:0];
// The bubble controller will release itself when the window closes.
@@ -253,7 +253,7 @@ TEST_F(BaseBubbleControllerTest, ResignKeyCloses) {
[[NSWindow alloc] initWithContentRect:NSMakeRect(500, 500, 500, 500)
styleMask:NSTitledWindowMask
backing:NSBackingStoreBuffered
- defer:YES]);
+ defer:NO]);
base::scoped_nsobject<BaseBubbleController> keep_alive = ShowBubble();
EXPECT_FALSE([other_window isVisible]);
@@ -364,7 +364,7 @@ TEST_F(BaseBubbleControllerTest, BubbleStaysOpenWithSheet) {
[[NSPanel alloc] initWithContentRect:NSMakeRect(0, 0, 100, 50)
styleMask:NSTitledWindowMask
backing:NSBackingStoreBuffered
- defer:YES]);
+ defer:NO]);
EXPECT_FALSE([panel isReleasedWhenClosed]); // scoped_nsobject releases it.
// With a NSOpenPanel, we would call -[NSSavePanel beginSheetModalForWindow]

Powered by Google App Engine
This is Rietveld 408576698