Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Side by Side Diff: chrome/browser/ui/cocoa/status_bubble_mac.mm

Issue 1154013009: [OSX] Don't create deferred windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/cocoa/status_bubble_mac.h" 5 #include "chrome/browser/ui/cocoa/status_bubble_mac.h"
6 6
7 #include <limits> 7 #include <limits>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
(...skipping 429 matching lines...) Expand 10 before | Expand all | Expand 10 after
440 UpdateSizeAndPosition(); 440 UpdateSizeAndPosition();
441 } 441 }
442 442
443 void StatusBubbleMac::Create() { 443 void StatusBubbleMac::Create() {
444 DCHECK(!window_); 444 DCHECK(!window_);
445 445
446 window_ = [[StatusBubbleWindow alloc] 446 window_ = [[StatusBubbleWindow alloc]
447 initWithContentRect:ui::kWindowSizeDeterminedLater 447 initWithContentRect:ui::kWindowSizeDeterminedLater
448 styleMask:NSBorderlessWindowMask 448 styleMask:NSBorderlessWindowMask
449 backing:NSBackingStoreBuffered 449 backing:NSBackingStoreBuffered
450 defer:YES]; 450 defer:NO];
451 [window_ setMovableByWindowBackground:NO]; 451 [window_ setMovableByWindowBackground:NO];
452 [window_ setBackgroundColor:[NSColor clearColor]]; 452 [window_ setBackgroundColor:[NSColor clearColor]];
453 [window_ setLevel:NSNormalWindowLevel]; 453 [window_ setLevel:NSNormalWindowLevel];
454 [window_ setOpaque:NO]; 454 [window_ setOpaque:NO];
455 [window_ setHasShadow:NO]; 455 [window_ setHasShadow:NO];
456 456
457 // We do not need to worry about the bubble outliving |parent_| because our 457 // We do not need to worry about the bubble outliving |parent_| because our
458 // teardown sequence in BWC guarantees that |parent_| outlives the status 458 // teardown sequence in BWC guarantees that |parent_| outlives the status
459 // bubble and that the StatusBubble is torn down completely prior to the 459 // bubble and that the StatusBubble is torn down completely prior to the
460 // window going away. 460 // window going away.
(...skipping 387 matching lines...) Expand 10 before | Expand all | Expand 10 after
848 } 848 }
849 849
850 // Round the top corners when the bubble is below the parent window. 850 // Round the top corners when the bubble is below the parent window.
851 if (NSMinY(window_frame) < NSMinY(parent_frame)) { 851 if (NSMinY(window_frame) < NSMinY(parent_frame)) {
852 corner_flags |= kRoundedTopLeftCorner | kRoundedTopRightCorner; 852 corner_flags |= kRoundedTopLeftCorner | kRoundedTopRightCorner;
853 } 853 }
854 } 854 }
855 855
856 return corner_flags; 856 return corner_flags;
857 } 857 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm ('k') | chrome/browser/ui/cocoa/tabs/tab_window_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698