Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 1153963006: [turbofan] Verify uses of Deoptimize and Return in graph. (Closed)

Created:
5 years, 7 months ago by Michael Starzinger
Modified:
5 years, 7 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Verify uses of Deoptimize and Return in graph. R=bmeurer@chromium.org Committed: https://crrev.com/3c13e81721d60120e5fbc54c4bb77fc980381faa Cr-Commit-Position: refs/heads/master@{#28624}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -7 lines) Patch
M src/compiler/verifier.cc View 1 2 chunks +19 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Michael Starzinger
5 years, 7 months ago (2015-05-26 11:14:38 UTC) #1
Benedikt Meurer
LGTM once comment is addressed. Thanks for doing this. https://codereview.chromium.org/1153963006/diff/1/src/compiler/verifier.cc File src/compiler/verifier.cc (right): https://codereview.chromium.org/1153963006/diff/1/src/compiler/verifier.cc#newcode275 src/compiler/verifier.cc:275: ...
5 years, 7 months ago (2015-05-26 11:23:08 UTC) #2
Michael Starzinger
Thanks. Landing. https://codereview.chromium.org/1153963006/diff/1/src/compiler/verifier.cc File src/compiler/verifier.cc (right): https://codereview.chromium.org/1153963006/diff/1/src/compiler/verifier.cc#newcode275 src/compiler/verifier.cc:275: CHECK(use->opcode() == IrOpcode::kEnd); On 2015/05/26 11:23:08, Benedikt ...
5 years, 7 months ago (2015-05-26 11:29:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1153963006/20001
5 years, 7 months ago (2015-05-26 11:30:59 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-26 11:52:49 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-26 11:53:08 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3c13e81721d60120e5fbc54c4bb77fc980381faa
Cr-Commit-Position: refs/heads/master@{#28624}

Powered by Google App Engine
This is Rietveld 408576698