[turbofan] Verify uses of Deoptimize and Return in graph.

[turbofan] Verify uses of Deoptimize and Return in graph.

R=bmeurer@chromium.org

Committed: https://crrev.com/3c13e81721d60120e5fbc54c4bb77fc980381faa
Cr-Commit-Position: refs/heads/master@{#28624}

[Benedikt Meurer, 2015-05-26 11:23:08]

LGTM once comment is addressed. Thanks for doing this.

https://codereview.chromium.org/1153963006/diff/1/src/compiler/verifier.cc
File src/compiler/verifier.cc (right):

https://codereview.chromium.org/1153963006/diff/1/src/compiler/verifier.cc#ne...
src/compiler/verifier.cc:275: CHECK(use->opcode() == IrOpcode::kEnd);
Please use CHECK_EQ(IrOpcode::kEnd, use->opcode()) here and below. Makes
debugging easier, since the output will tell you directly what's wrong.

[Michael Starzinger, 2015-05-26 11:29:15]

Thanks. Landing.

https://codereview.chromium.org/1153963006/diff/1/src/compiler/verifier.cc
File src/compiler/verifier.cc (right):

https://codereview.chromium.org/1153963006/diff/1/src/compiler/verifier.cc#ne...
src/compiler/verifier.cc:275: CHECK(use->opcode() == IrOpcode::kEnd);
On 2015/05/26 11:23:08, Benedikt Meurer wrote:
> Please use CHECK_EQ(IrOpcode::kEnd, use->opcode()) here and below. Makes
> debugging easier, since the output will tell you directly what's wrong.

Done.

[Michael Starzinger, 2015-05-26 11:30:43]

The CQ bit was checked by mstarzinger@chromium.org

[Michael Starzinger, 2015-05-26 11:30:43]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/1153963006/#ps20001
(title: "Addressed comments.")

[commit-bot: I haz the power, 2015-05-26 11:30:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1153963006/20001

[commit-bot: I haz the power, 2015-05-26 11:52:49]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-05-26 11:53:08]

Patchset 2 (id:??) landed as
https://crrev.com/3c13e81721d60120e5fbc54c4bb77fc980381faa
Cr-Commit-Position: refs/heads/master@{#28624}