Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Side by Side Diff: runtime/vm/stub_code_x64.cc

Issue 1153963002: Remove value check from ICData checks/house-keeping (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: C Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/stub_code_mips.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" 5 #include "vm/globals.h"
6 #if defined(TARGET_ARCH_X64) 6 #if defined(TARGET_ARCH_X64)
7 7
8 #include "vm/assembler.h" 8 #include "vm/assembler.h"
9 #include "vm/compiler.h" 9 #include "vm/compiler.h"
10 #include "vm/dart_entry.h" 10 #include "vm/dart_entry.h"
(...skipping 1528 matching lines...) Expand 10 before | Expand all | Expand 10 after
1539 1539
1540 void StubCode::GenerateTwoArgsCheckInlineCacheStub(Assembler* assembler) { 1540 void StubCode::GenerateTwoArgsCheckInlineCacheStub(Assembler* assembler) {
1541 GenerateUsageCounterIncrement(assembler, RCX); 1541 GenerateUsageCounterIncrement(assembler, RCX);
1542 GenerateNArgsCheckInlineCacheStub(assembler, 2, 1542 GenerateNArgsCheckInlineCacheStub(assembler, 2,
1543 kInlineCacheMissHandlerTwoArgsRuntimeEntry, 1543 kInlineCacheMissHandlerTwoArgsRuntimeEntry,
1544 Token::kILLEGAL, 1544 Token::kILLEGAL,
1545 kIgnoreRanges); 1545 kIgnoreRanges);
1546 } 1546 }
1547 1547
1548 1548
1549 void StubCode::GenerateThreeArgsCheckInlineCacheStub(Assembler* assembler) {
1550 GenerateUsageCounterIncrement(assembler, RCX);
1551 GenerateNArgsCheckInlineCacheStub(assembler, 3,
1552 kInlineCacheMissHandlerThreeArgsRuntimeEntry,
1553 Token::kILLEGAL,
1554 kIgnoreRanges);
1555 }
1556
1557
1558 void StubCode::GenerateSmiAddInlineCacheStub(Assembler* assembler) { 1549 void StubCode::GenerateSmiAddInlineCacheStub(Assembler* assembler) {
1559 GenerateUsageCounterIncrement(assembler, RCX); 1550 GenerateUsageCounterIncrement(assembler, RCX);
1560 GenerateNArgsCheckInlineCacheStub(assembler, 2, 1551 GenerateNArgsCheckInlineCacheStub(assembler, 2,
1561 kInlineCacheMissHandlerTwoArgsRuntimeEntry, 1552 kInlineCacheMissHandlerTwoArgsRuntimeEntry,
1562 Token::kADD, 1553 Token::kADD,
1563 kCollectRanges); 1554 kCollectRanges);
1564 } 1555 }
1565 1556
1566 1557
1567 void StubCode::GenerateSmiSubInlineCacheStub(Assembler* assembler) { 1558 void StubCode::GenerateSmiSubInlineCacheStub(Assembler* assembler) {
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
1626 void StubCode::GenerateTwoArgsOptimizedCheckInlineCacheStub( 1617 void StubCode::GenerateTwoArgsOptimizedCheckInlineCacheStub(
1627 Assembler* assembler) { 1618 Assembler* assembler) {
1628 GenerateOptimizedUsageCounterIncrement(assembler); 1619 GenerateOptimizedUsageCounterIncrement(assembler);
1629 GenerateNArgsCheckInlineCacheStub(assembler, 2, 1620 GenerateNArgsCheckInlineCacheStub(assembler, 2,
1630 kInlineCacheMissHandlerTwoArgsRuntimeEntry, 1621 kInlineCacheMissHandlerTwoArgsRuntimeEntry,
1631 Token::kILLEGAL, 1622 Token::kILLEGAL,
1632 kIgnoreRanges); 1623 kIgnoreRanges);
1633 } 1624 }
1634 1625
1635 1626
1636 void StubCode::GenerateThreeArgsOptimizedCheckInlineCacheStub(
1637 Assembler* assembler) {
1638 GenerateOptimizedUsageCounterIncrement(assembler);
1639 GenerateNArgsCheckInlineCacheStub(assembler, 3,
1640 kInlineCacheMissHandlerThreeArgsRuntimeEntry,
1641 Token::kILLEGAL,
1642 kIgnoreRanges);
1643 }
1644
1645
1646 // Intermediary stub between a static call and its target. ICData contains 1627 // Intermediary stub between a static call and its target. ICData contains
1647 // the target function and the call count. 1628 // the target function and the call count.
1648 // RBX: ICData 1629 // RBX: ICData
1649 void StubCode::GenerateZeroArgsUnoptimizedStaticCallStub(Assembler* assembler) { 1630 void StubCode::GenerateZeroArgsUnoptimizedStaticCallStub(Assembler* assembler) {
1650 GenerateUsageCounterIncrement(assembler, RCX); 1631 GenerateUsageCounterIncrement(assembler, RCX);
1651 #if defined(DEBUG) 1632 #if defined(DEBUG)
1652 { Label ok; 1633 { Label ok;
1653 // Check that the IC data array has NumArgsTested() == 0. 1634 // Check that the IC data array has NumArgsTested() == 0.
1654 // 'NumArgsTested' is stored in the least significant bits of 'state_bits'. 1635 // 'NumArgsTested' is stored in the least significant bits of 'state_bits'.
1655 __ movl(RCX, FieldAddress(RBX, ICData::state_bits_offset())); 1636 __ movl(RCX, FieldAddress(RBX, ICData::state_bits_offset()));
(...skipping 518 matching lines...) Expand 10 before | Expand all | Expand 10 after
2174 // Result: 2155 // Result:
2175 // RCX: entry point. 2156 // RCX: entry point.
2176 void StubCode::GenerateMegamorphicLookupStub(Assembler* assembler) { 2157 void StubCode::GenerateMegamorphicLookupStub(Assembler* assembler) {
2177 EmitMegamorphicLookup(assembler, RDI, RBX, RCX); 2158 EmitMegamorphicLookup(assembler, RDI, RBX, RCX);
2178 __ ret(); 2159 __ ret();
2179 } 2160 }
2180 2161
2181 } // namespace dart 2162 } // namespace dart
2182 2163
2183 #endif // defined TARGET_ARCH_X64 2164 #endif // defined TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « runtime/vm/stub_code_mips.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698