Source/core/animation/animatable/AnimatableValueKeyframe.h - Issue 1153943003: Add foundation for removing AnimatableValues from StyleInterpolation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/animation/animatable/AnimatableValueKeyframe.h

Issue 1153943003: Add foundation for removing AnimatableValues from StyleInterpolation (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Add missing header file Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/animation/StringKeyframe.cpp ('K') | « Source/core/animation/StringKeyframe.cpp ('k') | Source/core/animation/animatable/AnimatableValueKeyframe.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/animation/animatable/AnimatableValueKeyframe.h

diff --git a/Source/core/animation/animatable/AnimatableValueKeyframe.h b/Source/core/animation/animatable/AnimatableValueKeyframe.h

index e1533dbea4d7be341a274e70a384009159d3b29a..3fde6f365ef10200d42bfe977261e76c19fe26dc 100644

--- a/Source/core/animation/animatable/AnimatableValueKeyframe.h

+++ b/Source/core/animation/animatable/AnimatableValueKeyframe.h

@@ -38,15 +38,15 @@ public:

AnimatableValue* value() const { return m_value.get(); }

virtual const PassRefPtrWillBeRawPtr<AnimatableValue> getAnimatableValue() const override final { return m_value; }

- virtual PassOwnPtrWillBeRawPtr<Keyframe::PropertySpecificKeyframe> neutralKeyframe(double offset, PassRefPtr<TimingFunction> easing) const override final;

- virtual PassRefPtrWillBeRawPtr<Interpolation> maybeCreateInterpolation(PropertyHandle, Keyframe::PropertySpecificKeyframe& end, Element*, const ComputedStyle*) const override final;

+ virtual PassRefPtrWillBeRawPtr<Keyframe::PropertySpecificKeyframe> neutralKeyframe(double offset, PassRefPtr<TimingFunction> easing) const override final;

+ virtual PassRefPtrWillBeRawPtr<Interpolation> maybeCreateInterpolation(PropertyHandle, Keyframe::PropertySpecificKeyframe& end, Element*, const ComputedStyle*) override final;

DECLARE_VIRTUAL_TRACE();

private:

PropertySpecificKeyframe(double offset, PassRefPtr<TimingFunction> easing, PassRefPtrWillBeRawPtr<AnimatableValue>);

- virtual PassOwnPtrWillBeRawPtr<Keyframe::PropertySpecificKeyframe> cloneWithOffset(double offset) const override;

+ virtual PassRefPtrWillBeRawPtr<Keyframe::PropertySpecificKeyframe> cloneWithOffset(double offset) const override;

virtual bool isAnimatableValuePropertySpecificKeyframe() const override { return true; }

RefPtrWillBeMember<AnimatableValue> m_value;

@@ -58,7 +58,7 @@ private:

AnimatableValueKeyframe(const AnimatableValueKeyframe& copyFrom);

virtual PassRefPtrWillBeRawPtr<Keyframe> clone() const override;

- virtual PassOwnPtrWillBeRawPtr<Keyframe::PropertySpecificKeyframe> createPropertySpecificKeyframe(PropertyHandle) const override;

+ virtual PassRefPtrWillBeRawPtr<Keyframe::PropertySpecificKeyframe> createPropertySpecificKeyframe(PropertyHandle) const override;

virtual bool isAnimatableValueKeyframe() const override { return true; }