Update network service.

Update network service.

R=blundell@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/51b02e3b16631d9ef0827655ea9c688311cee5e8

[qsr, 2015-06-04 11:54:04]

qsr@chromium.org changed reviewers:
+ rogulenko@google.com

[qsr, 2015-06-04 11:54:04]

Sergey -> Do you mind patching this CL in, revert the change in
examples/go/BUILD.gn and try to build on Android?

This will fail with the following error:

[1170/2477] ACTION //examples/go:go_ht...rver_go(//build/toolchain/android:arm)
FAILED: python ../../mojo/go/go.py --android --
/usr/local/google/home/qsr/programmes/mojo/src/third_party/go/tool/android_arm/bin/go
obj/examples/go/go_http_server_go_build obj/examples/go/go_http_server_go ../../
../android_Debug -I/usr/local/google/home/qsr/programmes/mojo/src/
-L/usr/local/google/home/qsr/programmes/mojo/src/out/android_Debug/obj/examples/go\
-lgo_http_server_static_library build -ldflags=-shared
../../../../../../examples/go/http_server.go
# mojo/services/network/public/interfaces/url_loader_interceptor
../../../../gen/go/src/mojo/services/network/public/interfaces/url_loader_interceptor/url_loader_interceptor.mojom.go:218:
UrlLoaderInterceptorFactory redeclared in this block
        previous declaration at
../../../../gen/go/src/mojo/services/network/public/interfaces/url_loader_interceptor/url_loader_interceptor.mojom.go:22

 The issue seems to be that the mojom declare both Foo and FooFactory and that
somehow, the go bindings are already claiming FooFactory themselves. That
doesn't seem a good idea for the go bindings, because creating an service call
FooFactory that creates Foo seems quite expected.

 Can you take a look at this? Thanks.

[rogulenko, 2015-06-04 22:15:19]

On 2015/06/04 11:54:04, qsr wrote:
> Sergey -> Do you mind patching this CL in, revert the change in
> examples/go/BUILD.gn and try to build on Android?
> 
> This will fail with the following error:
> 
> [1170/2477] ACTION
//examples/go:go_ht...rver_go(//build/toolchain/android:arm)
> FAILED: python ../../mojo/go/go.py --android --
>
/usr/local/google/home/qsr/programmes/mojo/src/third_party/go/tool/android_arm/bin/go
> obj/examples/go/go_http_server_go_build obj/examples/go/go_http_server_go
../../
> ../android_Debug -I/usr/local/google/home/qsr/programmes/mojo/src/
>
-L/usr/local/google/home/qsr/programmes/mojo/src/out/android_Debug/obj/examples/go\
> -lgo_http_server_static_library build -ldflags=-shared
> ../../../../../../examples/go/http_server.go
> # mojo/services/network/public/interfaces/url_loader_interceptor
>
../../../../gen/go/src/mojo/services/network/public/interfaces/url_loader_interceptor/url_loader_interceptor.mojom.go:218:
> UrlLoaderInterceptorFactory redeclared in this block
>         previous declaration at
>
../../../../gen/go/src/mojo/services/network/public/interfaces/url_loader_interceptor/url_loader_interceptor.mojom.go:22
> 
>  The issue seems to be that the mojom declare both Foo and FooFactory and that
> somehow, the go bindings are already claiming FooFactory themselves. That
> doesn't seem a good idea for the go bindings, because creating an service call
> FooFactory that creates Foo seems quite expected.
> 
>  Can you take a look at this? Thanks.

Yes, I see the problem. I'll write a CL that changes naming in Go bindings to
fix it.

[qsr, 2015-06-05 12:42:11]

qsr@chromium.org changed reviewers:
+ blundell@chromium.org

[blundell, 2015-06-05 12:45:02]

lgtm

[qsr, 2015-06-05 12:57:36]

Committed patchset #5 (id:80001) manually as
51b02e3b16631d9ef0827655ea9c688311cee5e8 (presubmit successful).