Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3528)

Unified Diff: chrome/browser/ui/sync/one_click_signin_helper.cc

Issue 115393004: Turn on inline signin by default (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebased Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/sync/one_click_signin_helper.cc
diff --git a/chrome/browser/ui/sync/one_click_signin_helper.cc b/chrome/browser/ui/sync/one_click_signin_helper.cc
index 9d9768d1ee9a02b3d1a9db1bec00ca88cb6cc667..bd9ae9d95cc275579c341fddca15b24b25141e63 100644
--- a/chrome/browser/ui/sync/one_click_signin_helper.cc
+++ b/chrome/browser/ui/sync/one_click_signin_helper.cc
@@ -779,14 +779,12 @@ bool OneClickSigninHelper::CanOffer(content::WebContents* web_contents,
OneClickSigninHelper::Offer OneClickSigninHelper::CanOfferOnIOThread(
net::URLRequest* request,
ProfileIOData* io_data) {
- return CanOfferOnIOThreadImpl(request->url(), request->referrer(),
- request, io_data);
+ return CanOfferOnIOThreadImpl(request->url(), request, io_data);
}
// static
OneClickSigninHelper::Offer OneClickSigninHelper::CanOfferOnIOThreadImpl(
const GURL& url,
- const std::string& referrer,
base::SupportsUserData* request,
ProfileIOData* io_data) {
if (!gaia::IsGaiaSignonRealm(url.GetOrigin()))
@@ -1169,8 +1167,6 @@ void OneClickSigninHelper::DidStartNavigationToPendingEntry(
// clear the internal state. This is needed to detect navigations in the
// middle of the sign in process that may redirect back to the sign in
// process (see crbug.com/181163 for details).
- const GURL continue_url = signin::GetNextPageURLForPromoURL(
- signin::GetPromoURL(signin::SOURCE_START_PAGE, false));
GURL::Replacements replacements;
replacements.ClearQuery();

Powered by Google App Engine
This is Rietveld 408576698