Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7749)

Unified Diff: chrome/browser/ui/views/profile_chooser_view.cc

Issue 115393004: Turn on inline signin by default (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/profile_chooser_view.cc
diff --git a/chrome/browser/ui/views/profile_chooser_view.cc b/chrome/browser/ui/views/profile_chooser_view.cc
index 328b94a75a3306a4aee12de7170ecf3390b7b25d..f6a882297d0390a8565ea630764a20dc4b1231e3 100644
--- a/chrome/browser/ui/views/profile_chooser_view.cc
+++ b/chrome/browser/ui/views/profile_chooser_view.cc
@@ -4,7 +4,6 @@
#include "chrome/browser/ui/views/profile_chooser_view.h"
-#include "base/command_line.h"
#include "base/strings/utf_string_conversions.h"
#include "chrome/browser/browser_process.h"
#include "chrome/browser/profiles/profile_info_util.h"
@@ -20,7 +19,6 @@
#include "chrome/browser/ui/browser_dialogs.h"
#include "chrome/browser/ui/singleton_tabs.h"
#include "chrome/browser/ui/views/user_manager_view.h"
-#include "chrome/common/chrome_switches.h"
#include "chrome/common/url_constants.h"
#include "grit/chromium_strings.h"
#include "grit/generated_resources.h"
@@ -570,13 +568,7 @@ void ProfileChooserView::LinkClicked(views::Link* sender, int event_flags) {
profiles::LockProfile(browser_->profile());
} else {
DCHECK(sender == signin_current_profile_link_);
- if (CommandLine::ForCurrentProcess()->HasSwitch(
- switches::kEnableInlineSignin)) {
- ShowView(GAIA_SIGNIN_VIEW, avatar_menu_.get());
- } else {
- GURL page = signin::GetPromoURL(signin::SOURCE_MENU, false);
- chrome::ShowSingletonTab(browser_, page);
- }
+ ShowView(GAIA_SIGNIN_VIEW, avatar_menu_.get());
Roger Tawa OOO till Jul 10th 2013/12/17 20:59:18 Why take out the else case?
guohui 2013/12/17 23:00:25 because the avatar bubble should always use the em
}
}

Powered by Google App Engine
This is Rietveld 408576698