Add a menu option for the right-hand Ctrl -> Meta mapping.

remoting/webapp/crd/js/options_menu.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * Class handling the in-session options menu (or menus in the case of apps v1).
  */
 
 'use strict';
 
 /** @suppress {duplicate} */
 var remoting = remoting || {};
 
 /**
  * @param {Element} sendCtrlAltDel
  * @param {Element} sendPrtScrn
+ * @param {Element} mapRightCtrl
  * @param {Element} resizeToClient
  * @param {Element} shrinkToFit
  * @param {Element} newConnection
  * @param {Element?} fullscreen
  * @param {Element?} toggleStats
  * @param {Element?} startStopRecording
  * @constructor
  */
-remoting.OptionsMenu = function(sendCtrlAltDel, sendPrtScrn,
+remoting.OptionsMenu = function(sendCtrlAltDel, sendPrtScrn, mapRightCtrl,
                                 resizeToClient, shrinkToFit,
                                 newConnection, fullscreen, toggleStats,
                                 startStopRecording) {
   this.sendCtrlAltDel_ = sendCtrlAltDel;
   this.sendPrtScrn_ = sendPrtScrn;
+  this.mapRightCtrl_ = mapRightCtrl;
   this.resizeToClient_ = resizeToClient;
   this.shrinkToFit_ = shrinkToFit;
   this.newConnection_ = newConnection;
   this.fullscreen_ = fullscreen;
   this.toggleStats_ = toggleStats;
   this.startStopRecording_ = startStopRecording;
 
   /** @private {remoting.DesktopConnectedView} */
   this.desktopConnectedView_ = null;
 
   this.sendCtrlAltDel_.addEventListener(
       'click', this.onSendCtrlAltDel_.bind(this), false);
   this.sendPrtScrn_.addEventListener(
       'click', this.onSendPrtScrn_.bind(this), false);
+  this.mapRightCtrl_.addEventListener(
+      'click', this.onMapRightCtrl_.bind(this), false);
   this.resizeToClient_.addEventListener(
       'click', this.onResizeToClient_.bind(this), false);
   this.shrinkToFit_.addEventListener(
       'click', this.onShrinkToFit_.bind(this), false);
   this.newConnection_.addEventListener(
       'click', this.onNewConnection_.bind(this), false);
 
   if (this.fullscreen_) {
     fullscreen.addEventListener('click', this.onFullscreen_.bind(this), false);
   }
@@ skipping 15 matching lines @@
     desktopConnectedView) {
   this.desktopConnectedView_ = desktopConnectedView;
 };
 
 remoting.OptionsMenu.prototype.onShow = function() {
   if (this.desktopConnectedView_) {
     base.debug.assert(remoting.app instanceof remoting.DesktopRemoting);
     var drApp = /** @type {remoting.DesktopRemoting} */ (remoting.app);
     var mode = drApp.getConnectionMode();
 
+    remoting.MenuButton.select(
+        this.mapRightCtrl_, this.desktopConnectedView_.getMapRightCtrl());

[Wez, 2015/06/01 19:47:57]

Do we want to show this option even on non-ChromeOS? It's really only required
to work-around ChromeOS having the option of running with Search not mapped to
OSKey.

[Jamie, 2015/06/01 19:59:51]

I think you're probably right. I was thinking that it might be useful on any
system that might have a limited keyboard, but let's wait and see if there's a
use-case for that before complicating the UI.

[Wez, 2015/06/02 17:32:56]

SGTM

If we're going to make this general purpose then I'd suggest we do it as a more
general keyboard-configuration UI, with some simple defaults/presets, for
example.

+
     this.resizeToClient_.hidden = mode === remoting.DesktopRemoting.Mode.IT2ME;
     remoting.MenuButton.select(
         this.resizeToClient_, this.desktopConnectedView_.getResizeToClient());
     remoting.MenuButton.select(
         this.shrinkToFit_, this.desktopConnectedView_.getShrinkToFit());
 
     if (this.fullscreen_) {
       remoting.MenuButton.select(
           this.fullscreen_, remoting.fullscreen.isActive());
     }
@@ skipping 20 matching lines @@
     this.desktopConnectedView_.sendCtrlAltDel();
   }
 };
 
 remoting.OptionsMenu.prototype.onSendPrtScrn_ = function() {
   if (this.desktopConnectedView_) {
     this.desktopConnectedView_.sendPrintScreen();
   }
 };
 
+remoting.OptionsMenu.prototype.onMapRightCtrl_ = function() {
+  if (this.desktopConnectedView_) {
+    this.desktopConnectedView_.setMapRightCtrl(
+        !this.desktopConnectedView_.getMapRightCtrl());
+  }
+};
+
 remoting.OptionsMenu.prototype.onResizeToClient_ = function() {
   if (this.desktopConnectedView_) {
     this.desktopConnectedView_.setScreenMode(
         this.desktopConnectedView_.getShrinkToFit(),
         !this.desktopConnectedView_.getResizeToClient());
   }
 };
 
 remoting.OptionsMenu.prototype.onShrinkToFit_ = function() {
   if (this.desktopConnectedView_) {
@@ skipping 24 matching lines @@
 remoting.OptionsMenu.prototype.onStartStopRecording_ = function() {
   if (this.desktopConnectedView_) {
     this.desktopConnectedView_.startStopRecording();
   }
 };
 
 /**
  * @type {remoting.OptionsMenu}
  */
 remoting.optionsMenu = null;