Add a menu option for the right-hand Ctrl -> Meta mapping.

remoting/webapp/crd/js/desktop_connected_view.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * Class handling user-facing aspects of the client session.
  */
 
 'use strict';
@@ skipping 88 matching lines @@
 /**
  * @return {boolean} True if resize-to-client is enabled; false otherwise.
  */
 remoting.DesktopConnectedView.prototype.getResizeToClient = function() {
   if (this.viewport_) {
     return this.viewport_.getResizeToClient();
   }
   return false;
 };
 
+/**
+ * @return {boolean} True if the right-hand Ctrl key should be remapped to the

[kelvinp, 2015/06/05 20:47:58]

s/should be remapped/is current mapped

[Jamie, 2015/06/05 20:58:41]

Done.

+ *     Meta (Windows, Command) key.
+ */
+remoting.DesktopConnectedView.prototype.getMapRightCtrl = function() {
+  return this.host_.options.remapKeys[0x0700e4] == 0x0700e7;

[kelvinp, 2015/06/05 20:47:58]

use === equals

[Jamie, 2015/06/05 20:58:41]

Done.

+};
+
 remoting.DesktopConnectedView.prototype.toggleStats = function() {
   this.stats_.toggle();
 };
 
 /**
  * @return {boolean} True if the connection stats is visible; false otherwise.
  */
 remoting.DesktopConnectedView.prototype.isStatsVisible = function() {
   return this.stats_.isVisible();
 };
@@ skipping 109 matching lines @@
     // Fullscreen.isActive call is not guaranteed to return true until the
     // full-screen event is triggered. In apps v2, the size of the window's
     // client area is calculated differently in full-screen mode, so register
     // for both events.
     this.viewport_.onResize();
     this.viewport_.enableBumpScroll(Boolean(fullscreen));
   }
 };
 
 /**
+ * Set whether or not the right-hand Ctrl key should send the Meta (Windows,
+ * Command) key-code.
+ *
+ * @param {boolean} enable True to enable the mapping; false to disable.
+ */
+remoting.DesktopConnectedView.prototype.setMapRightCtrl = function(enable) {
+  if (enable === this.getMapRightCtrl()) {

[kelvinp, 2015/06/05 20:47:58]

Nit: No need to use === to compare with boolean, e.g.
if(getMapRightCtrl()) {}

[Jamie, 2015/06/05 20:58:41]

I'm not comparing to true; I'm early-exiting if the function should be a no-op.

[kelvinp, 2015/06/06 00:54:26]

Sorry, I misread

+    return;  // In case right Ctrl is mapped, but not to right Meta.
+  }
+
+  if (enable) {
+    this.host_.options.remapKeys[0x0700e4] = 0x0700e7;
+  } else {
+    delete this.host_.options.remapKeys[0x0700e4]
+  }
+  this.setRemapKeys(this.host_.options.remapKeys);
+};
+
+/**
  * Sends a Ctrl-Alt-Del sequence to the remoting client.
  *
  * @return {void} Nothing.
  */
 remoting.DesktopConnectedView.prototype.sendCtrlAltDel = function() {
   console.log('Sending Ctrl-Alt-Del.');
   this.plugin_.injectKeyCombination([0x0700e0, 0x0700e2, 0x07004c]);
 };
 
 /**
  * Sends a Print Screen keypress to the remoting client.
  *
  * @return {void} Nothing.
  */
 remoting.DesktopConnectedView.prototype.sendPrintScreen = function() {
   console.log('Sending Print Screen.');
   this.plugin_.injectKeyCombination([0x070046]);
 };
 
 /**
  * Sets and stores the key remapping setting for the current host. If set,
  * these mappings override the defaults for the client platform.
  *
  * @param {!Object} remappings
  */
 remoting.DesktopConnectedView.prototype.setRemapKeys = function(remappings) {
   this.plugin_.setRemapKeys(remappings);
   // Save the new remapping setting.
-  this.host_.options.remapKeys = remappings;
+  this.host_.options.remapKeys =
+      /** @type {!Object} */ (base.deepCopy(remappings));
   this.host_.options.save();
 };
 
 /** @param {remoting.VideoFrameRecorder} recorder */
 remoting.DesktopConnectedView.prototype.setVideoFrameRecorder =
     function(recorder) {
   this.videoFrameRecorder_ = recorder;
 };
 
 /**
@@ skipping 16 matching lines @@
 };
 
 /**
  * Starts or stops recording of video frames.
  */
 remoting.DesktopConnectedView.prototype.startStopRecording = function() {
   if (this.videoFrameRecorder_) {
     this.videoFrameRecorder_.startStopRecording();
   }
 };