chrome/browser/autofill/autofill_manager.h - Issue 11539003: Pop up requestAutocomplete UI when autofill server hints chrome client that it is in a multipage au…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/autofill/autofill_manager.h

Issue 11539003: Pop up requestAutocomplete UI when autofill server hints chrome client that it is in a multipage au… (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Refactor autofill_manager to expose GetWebContents(). Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/autofill/autocheckout_manager.h ('K') | « chrome/browser/autofill/autocheckout_manager.cc ('k') | chrome/browser/autofill/autofill_manager.cc » ('j') | chrome/browser/autofill/autofill_metrics_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/autofill/autofill_manager.h

diff --git a/chrome/browser/autofill/autofill_manager.h b/chrome/browser/autofill/autofill_manager.h

index e2edbd5bb1111cbc9cd7dd657522514c5e6c82f1..da8abba0353ff7361c78b3f1a2158022e9792fc3 100644

--- a/chrome/browser/autofill/autofill_manager.h

+++ b/chrome/browser/autofill/autofill_manager.h

@@ -21,12 +21,14 @@

#include "base/string16.h"

#include "base/time.h"

#include "chrome/browser/api/sync/profile_sync_service_observer.h"

+#include "chrome/browser/autofill/autocheckout_manager.h"

#include "chrome/browser/autofill/autocomplete_history_manager.h"

#include "chrome/browser/autofill/autofill_download.h"

#include "chrome/browser/autofill/field_types.h"

#include "chrome/browser/autofill/form_structure.h"

#include "chrome/browser/autofill/personal_data_manager.h"

#include "chrome/common/autofill/autocheckout_status.h"

+#include "chrome/common/form_data.h"

#include "content/public/browser/web_contents_observer.h"

#include "content/public/common/ssl_status.h"

#include "third_party/WebKit/Source/WebKit/chromium/public/WebFormElement.h"

@@ -107,6 +109,9 @@ class AutofillManager : public content::WebContentsObserver,

// Remove the specified Autocomplete entry.

void RemoveAutocompleteEntry(const string16& name, const string16& value);

+ // Returns the present web_contents state.

+ content::WebContents* GetWebContents() const;

Ilya Sherman 2013/01/18 01:45:02 nit: This method should either return a const refe

Raman Kakilate 2013/01/18 04:22:30 Done.

protected:

// Only test code should subclass AutofillManager.

friend class base::RefCounted<AutofillManager>;

@@ -336,6 +341,9 @@ class AutofillManager : public content::WebContentsObserver,

// Handles single-field autocomplete form data.

AutocompleteHistoryManager autocomplete_history_manager_;

+ // Handles autocheckout flows.

+ AutocheckoutManager autocheckout_manager_;

// For logging UMA metrics. Overridden by metrics tests.

scoped_ptr<const AutofillMetrics> metric_logger_;

// Have we logged whether Autofill is enabled for this page load?