Pop up requestAutocomplete UI when autofill server hints chrome client that it is in a multipage au…

chrome/browser/autofill/autofill_manager.h

Index: chrome/browser/autofill/autofill_manager.h
diff --git a/chrome/browser/autofill/autofill_manager.h b/chrome/browser/autofill/autofill_manager.h
index e2edbd5bb1111cbc9cd7dd657522514c5e6c82f1..ff436b3624f5c30f464e8692adbebf4c12f6f721 100644
--- a/chrome/browser/autofill/autofill_manager.h
+++ b/chrome/browser/autofill/autofill_manager.h
@@ -21,16 +21,19 @@
 #include "base/string16.h"
 #include "base/time.h"
 #include "chrome/browser/api/sync/profile_sync_service_observer.h"
+#include "chrome/browser/autofill/autocheckout_manager.h"
 #include "chrome/browser/autofill/autocomplete_history_manager.h"
 #include "chrome/browser/autofill/autofill_download.h"
 #include "chrome/browser/autofill/field_types.h"
 #include "chrome/browser/autofill/form_structure.h"
 #include "chrome/browser/autofill/personal_data_manager.h"
 #include "chrome/common/autofill/autocheckout_status.h"
+#include "chrome/common/form_data.h"
 #include "content/public/browser/web_contents_observer.h"
 #include "content/public/common/ssl_status.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebFormElement.h"
 
+class AutocheckoutManager;

[Ilya Sherman, 2013/01/17 01:21:44]

nit: Omit this; it's redundant with the #include above.

[Raman Kakilate, 2013/01/17 06:40:33]

Done.

 class AutofillExternalDelegate;
 class AutofillField;
 class AutofillProfile;
@@ -107,6 +110,12 @@ class AutofillManager : public content::WebContentsObserver,
   // Remove the specified Autocomplete entry.
   void RemoveAutocompleteEntry(const string16& name, const string16& value);
 
+  // Show dialog for autocheckout. |frame_url| and |ssl_status| are used to
+  // hint the user about security.
+  virtual void ShowAutocheckoutDialog(
+      const GURL& frame_url,
+      const content::SSLStatus& ssl_status);

[Ilya Sherman, 2013/01/17 01:21:44]

This should be part of the AutocheckoutManager class.

[Raman Kakilate, 2013/01/17 06:40:33]

this method is required to proxy web_contents() to AutocheckoutManager. Please
suggest if you see any other options.

+
  protected:
   // Only test code should subclass AutofillManager.
   friend class base::RefCounted<AutofillManager>;
@@ -336,6 +345,9 @@ class AutofillManager : public content::WebContentsObserver,
   // Handles single-field autocomplete form data.
   AutocompleteHistoryManager autocomplete_history_manager_;
 
+  // Handles autocheckout flows.
+  scoped_refptr<AutocheckoutManager> autocheckout_manager_;

[Ilya Sherman, 2013/01/17 01:21:44]

Why is this class reference counted?  You should just be able to declare this as
"AutocheckoutManager autocheckout_manager_;"

[Raman Kakilate, 2013/01/17 06:40:33]

AutcheckoutManager::ReturnAutocheckoutData has to be a callback and hence
RefCounted
(http://code.google.com/searchframe#OAMlx_jo-ck/src/base/bind_internal.h&exact...).
I might be missing a trick here.

+
   // For logging UMA metrics. Overridden by metrics tests.
   scoped_ptr<const AutofillMetrics> metric_logger_;
   // Have we logged whether Autofill is enabled for this page load?