Pop up requestAutocomplete UI when autofill server hints chrome client that it is in a multipage au…

chrome/browser/autofill/autofill_manager.h

Index: chrome/browser/autofill/autofill_manager.h
diff --git a/chrome/browser/autofill/autofill_manager.h b/chrome/browser/autofill/autofill_manager.h
index 8318480bb84831b5b06d4a4556ca38c33c314fc9..951c67534d39d9f8fd53b4ccac076af5938afb4b 100644
--- a/chrome/browser/autofill/autofill_manager.h
+++ b/chrome/browser/autofill/autofill_manager.h
@@ -26,6 +26,7 @@
 #include "chrome/browser/autofill/field_types.h"
 #include "chrome/browser/autofill/form_structure.h"
 #include "chrome/browser/autofill/personal_data_manager.h"
+#include "chrome/common/form_data.h"

[Ilya Sherman, 2013/01/15 06:31:52]

nit: Move this to the .cc file.

[Raman Kakilate, 2013/01/15 23:02:33]

Removed here.

 #include "content/public/browser/web_contents_observer.h"
 #include "content/public/common/ssl_status.h"
 
@@ -105,6 +106,10 @@ class AutofillManager : public content::WebContentsObserver,
   // Remove the specified Autocomplete entry.
   void RemoveAutocompleteEntry(const string16& name, const string16& value);
 
+  virtual void ShowAutofillFlowDialog(const FormData& form,
+                                      const GURL& frame_url,
+                                      const content::SSLStatus& ssl_status);

[Ilya Sherman, 2013/01/15 06:31:52]

Please create a new file named something like AutocheckoutManager to house all
of the Autocheckout code.  The AutofillManager class is already quite sprawling;
let's not exacerbate that while the code is still easy to untangle.

[Raman Kakilate, 2013/01/15 23:02:33]

I am little confused about what you mean by AutocheckoutManager. Should it
inherit WebContentsObserver similar to AutofillManager and listen to similar
messages from renderer and plug the popping up UI thing from AutocheckoutManager
? If yes, we might have to extract FormStructure once more in
AutocheckoutManager, and this approach seems like overkill.

Or do you mean AutocheckoutManager to be an object contained within
AutofillManager (exposing ShowAutocheckoutFlowDialog and
ReturnAutocheckoutFlowData methods) ? In this case, we need reference of
web_content() to be passed to AutocheckoutManager from Autofill server to init
AutofillDialogController.

Non of the options look good. Please advice.
Present approach I took is extract any utilities required for autocheckout into
autocheckout_util, and have the browser->render interactions done in
autofill_manager itself.

[Ilya Sherman, 2013/01/15 23:24:46]

I mean option (2): Have the AutofillManager call methods on AutocheckoutManager,
and pass in any needed dependencies.  What do you dislike about this approach?

[Raman Kakilate, 2013/01/16 19:20:12]

Ack. Refactored code.

I disliked AutofillManager acting as a proxy, but I now think its fine.

+
  protected:
   // Only test code should subclass AutofillManager.
   friend class base::RefCounted<AutofillManager>;
@@ -237,6 +242,9 @@ class AutofillManager : public content::WebContentsObserver,
   // Passes return data for an OnRequestAutocomplete call back to the page.
   void ReturnAutocompleteData(const FormStructure* result);
 
+  // Passes return data for an ShowAutofillFlowDialog call back to the page.
+  void ReturnAutofillFlowData(const FormStructure* result);
+
   // Fills |host| with the RenderViewHost for this tab.
   // Returns false if Autofill is disabled or if the host is unavailable.
   bool GetHost(content::RenderViewHost** host) const WARN_UNUSED_RESULT;