Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3389)

Unified Diff: chrome/browser/autofill/autofill_xml_parser.cc

Issue 11539003: Pop up requestAutocomplete UI when autofill server hints chrome client that it is in a multipage au… (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Addressed review comments. Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autofill/autofill_xml_parser.cc
diff --git a/chrome/browser/autofill/autofill_xml_parser.cc b/chrome/browser/autofill/autofill_xml_parser.cc
index 92a1ede91c0f94dbc96794d4060b2c51af488145..407918f4f9b1d4ab7d894690de6b1091ecf9dc52 100644
--- a/chrome/browser/autofill/autofill_xml_parser.cc
+++ b/chrome/browser/autofill/autofill_xml_parser.cc
@@ -33,6 +33,8 @@ AutofillQueryXmlParser::AutofillQueryXmlParser(
std::string* experiment_id)
: field_types_(field_types),
upload_required_(upload_required),
+ page_number_(-1),
Albert Bodenhamer 2013/01/14 22:10:18 nit: I assume -1 is illegal? Maybe create a const
Raman Kakilate 2013/01/14 23:37:46 -1 is being used in similar fashion at http://cod
+ total_pages_(-1),
experiment_id_(experiment_id) {
DCHECK(upload_required_);
DCHECK(experiment_id_);
@@ -89,6 +91,19 @@ void AutofillQueryXmlParser::StartElement(buzz::XmlParseContext* context,
// Record this field type.
field_types_->push_back(field_type);
+ } else if (element.compare("autofill_flow") == 0) {
+ // |attrs| is a NULL-terminated list of (attribute, value) pairs.
+ while (*attrs) {
+ buzz::QName attribute_qname = context->ResolveQName(*attrs, true);
+ ++attrs;
+ const std::string& attribute_name = attribute_qname.LocalPart();
+ if (attribute_name.compare("page_no") == 0) {
+ page_number_ = GetIntValue(context, *attrs);
+ } else if (attribute_name.compare("total_pages") == 0) {
+ total_pages_ = GetIntValue(context, *attrs);
+ }
+ ++attrs;
+ }
}
}

Powered by Google App Engine
This is Rietveld 408576698