Pop up requestAutocomplete UI when autofill server hints chrome client that it is in a multipage au…

chrome/browser/autofill/autofill_flow_infobar_delegate.h

Index: chrome/browser/autofill/autofill_flow_infobar_delegate.h
diff --git a/chrome/browser/autofill/autofill_flow_infobar_delegate.h b/chrome/browser/autofill/autofill_flow_infobar_delegate.h
new file mode 100644
index 0000000000000000000000000000000000000000..20eb366c4922dc65d8a05390d55f36525525955f
--- /dev/null
+++ b/chrome/browser/autofill/autofill_flow_infobar_delegate.h
@@ -0,0 +1,93 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_AUTOFILL_AUTOFILL_FLOW_INFOBAR_DELEGATE_H_
+#define CHROME_BROWSER_AUTOFILL_AUTOFILL_FLOW_INFOBAR_DELEGATE_H_
+
+#include "base/basictypes.h"
+#include "base/gtest_prod_util.h"
+#include "base/memory/scoped_ptr.h"
+#include "base/string16.h"
+#include "chrome/browser/api/infobars/confirm_infobar_delegate.h"
+#include "chrome/browser/autofill/autofill_manager.h"
+#include "chrome/browser/autofill/autofill_metrics.h"
+#include "chrome/common/form_data.h"
+#include "webkit/glue/window_open_disposition.h"
+
+namespace content {
+struct LoadCommittedDetails;
+struct SSLStatus;
+}
+
+// An InfoBar delegate that enables the user to allow or deny storing credit
+// card information gathered from a form submission.
+class AutofillFlowInfoBarDelegate : public ConfirmInfoBarDelegate {
+ public:
+  // Creates an autofillflow infobar delegate and adds it to |infobar_service|.
+  static void Create(InfoBarService* infobar_service,
+                     AutofillManager* autofill_manager,
+                     const AutofillMetrics* metric_logger,
+                     const GURL& source_url,
+                     const content::SSLStatus& ssl_status);
+
+#if defined(UNIT_TEST)
+  static scoped_ptr<ConfirmInfoBarDelegate> Create(

[Albert Bodenhamer, 2013/01/14 22:10:18]

It would be good to unify the 2 different Create methods.  #if
defined(UNIT_TEST) is best avoided (code clutter and consistency)

The best approach would probably be to have it always return the pointer and
make the caller responsible for adding it to |infobar_service|

At a minumum please use the same order for the params.

[Raman Kakilate, 2013/01/14 23:37:46]

I am being consistent with
http://code.google.com/searchframe#OAMlx_jo-ck/src/chrome/browser/autofill/au...

Infobars were recently refactored to this state.
CL: http://src.chromium.org/viewvc/chrome?view=rev&revision=175467

+      AutofillManager* autofill_manager,
+      const AutofillMetrics* metric_logger,
+      const GURL& source_url,
+      const content::SSLStatus& ssl_status) {
+    return scoped_ptr<ConfirmInfoBarDelegate>(new AutofillFlowInfoBarDelegate(
+        NULL, autofill_manager, metric_logger, source_url, ssl_status));
+  }
+#endif
+
+ private:
+  AutofillFlowInfoBarDelegate(InfoBarService* infobar_service,
+                              AutofillManager* autofill_manager,
+                              const AutofillMetrics* metric_logger,
+                              const GURL& source_url,
+                              const content::SSLStatus& ssl_status);
+
+  virtual ~AutofillFlowInfoBarDelegate();
+
+  void LogUserAction(AutofillMetrics::InfoBarMetric user_action);

[Albert Bodenhamer, 2013/01/14 22:10:18]

LogUserAction makes me think that you're recording some debug output.  I know
the name is consistent with other metrics logging funtions.  Maybe add a comment
to make this a bit more clear?

[Raman Kakilate, 2013/01/14 23:37:46]

Done.

+
+  // ConfirmInfoBarDelegate:
+  virtual void InfoBarDismissed() OVERRIDE;
+  virtual gfx::Image* GetIcon() const OVERRIDE;
+  virtual Type GetInfoBarType() const OVERRIDE;
+  virtual bool ShouldExpireInternal(
+      const content::LoadCommittedDetails& details) const OVERRIDE;
+  virtual string16 GetMessageText() const OVERRIDE;
+  virtual string16 GetButtonLabel(InfoBarButton button) const OVERRIDE;
+  virtual bool Accept() OVERRIDE;
+  virtual bool Cancel() OVERRIDE;
+  virtual string16 GetLinkText() const OVERRIDE;
+  virtual bool LinkClicked(WindowOpenDisposition disposition) OVERRIDE;
+
+  // For logging UMA metrics.
+  // Weak reference. Owned by the AutofillManager that initiated this infobar.
+  const AutofillMetrics* metric_logger_;
+
+  // To callback AutofillManager's ShowAutofillFlowDialog.
+  AutofillManager* autofill_manager_;
+
+  // URL of the page which triggered infobar.
+  GURL source_url_;
+
+  // SSL status of the page which triggered infobar.
+  content::SSLStatus ssl_status_;
+
+  // Did the user ever explicitly accept or dismiss this infobar?
+  bool had_user_interaction_;
+
+  // AutofillFlow Formdata to be used.
+  FormData autofill_flow_form_data_;
+
+  FRIEND_TEST_ALL_PREFIXES(AutofillMetricsTest, AutofillFlowInfoBar);
+
+  DISALLOW_COPY_AND_ASSIGN(AutofillFlowInfoBarDelegate);
+};
+
+#endif  // CHROME_BROWSER_AUTOFILL_AUTOFILL_FLOW_INFOBAR_DELEGATE_H_