Pop up requestAutocomplete UI when autofill server hints chrome client that it is in a multipage au…

chrome/browser/autofill/autofill_manager.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_AUTOFILL_AUTOFILL_MANAGER_H_
 #define CHROME_BROWSER_AUTOFILL_AUTOFILL_MANAGER_H_
 
 #include <list>
 #include <map>
 #include <string>
 #include <vector>
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
 #include "base/gtest_prod_util.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/scoped_vector.h"
 #include "base/memory/weak_ptr.h"
 #include "base/prefs/public/pref_change_registrar.h"
 #include "base/string16.h"
 #include "base/time.h"
 #include "chrome/browser/api/sync/profile_sync_service_observer.h"
+#include "chrome/browser/autofill/autocheckout_manager.h"
 #include "chrome/browser/autofill/autocomplete_history_manager.h"
 #include "chrome/browser/autofill/autofill_download.h"
 #include "chrome/browser/autofill/field_types.h"
 #include "chrome/browser/autofill/form_structure.h"
 #include "chrome/browser/autofill/personal_data_manager.h"
 #include "chrome/common/autofill/autocheckout_status.h"
+#include "chrome/common/form_data.h"
 #include "content/public/browser/web_contents_observer.h"
 #include "content/public/common/ssl_status.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebFormElement.h"
 
+class AutocheckoutManager;

[Ilya Sherman, 2013/01/17 01:21:44]

nit: Omit this; it's redundant with the #include above.

[Raman Kakilate, 2013/01/17 06:40:33]

Done.

 class AutofillExternalDelegate;
 class AutofillField;
 class AutofillProfile;
 class AutofillMetrics;
 class CreditCard;
 class FormGroup;
 class GURL;
 class PrefServiceSyncable;
 class ProfileSyncService;
 
@@ skipping 56 matching lines @@
                                      int max_length,
                                      const content::PasswordForm& form);
 
   // Remove the credit card or Autofill profile that matches |unique_id|
   // from the database.
   void RemoveAutofillProfileOrCreditCard(int unique_id);
 
   // Remove the specified Autocomplete entry.
   void RemoveAutocompleteEntry(const string16& name, const string16& value);
 
+  // Show dialog for autocheckout. |frame_url| and |ssl_status| are used to
+  // hint the user about security.
+  virtual void ShowAutocheckoutDialog(
+      const GURL& frame_url,
+      const content::SSLStatus& ssl_status);

[Ilya Sherman, 2013/01/17 01:21:44]

This should be part of the AutocheckoutManager class.

[Raman Kakilate, 2013/01/17 06:40:33]

this method is required to proxy web_contents() to AutocheckoutManager. Please
suggest if you see any other options.

+
  protected:
   // Only test code should subclass AutofillManager.
   friend class base::RefCounted<AutofillManager>;
 
   AutofillManager(content::WebContents* web_contents,
                   autofill::AutofillManagerDelegate* delegate);
   virtual ~AutofillManager();
 
   // Test code should prefer to use this constructor.
   AutofillManager(content::WebContents* web_contents,
@@ skipping 209 matching lines @@
 
   // Should be set to true in AutofillManagerTest and other tests, false in
   // AutofillDownloadManagerTest and in non-test environment. Is false by
   // default for the public constructor, and true by default for the test-only
   // constructors.
   bool disable_download_manager_requests_;
 
   // Handles single-field autocomplete form data.
   AutocompleteHistoryManager autocomplete_history_manager_;
 
+  // Handles autocheckout flows.
+  scoped_refptr<AutocheckoutManager> autocheckout_manager_;

[Ilya Sherman, 2013/01/17 01:21:44]

Why is this class reference counted?  You should just be able to declare this as
"AutocheckoutManager autocheckout_manager_;"

[Raman Kakilate, 2013/01/17 06:40:33]

AutcheckoutManager::ReturnAutocheckoutData has to be a callback and hence
RefCounted
(http://code.google.com/searchframe#OAMlx_jo-ck/src/base/bind_internal.h&exact...).
I might be missing a trick here.

+
   // For logging UMA metrics. Overridden by metrics tests.
   scoped_ptr<const AutofillMetrics> metric_logger_;
   // Have we logged whether Autofill is enabled for this page load?
   bool has_logged_autofill_enabled_;
   // Have we logged an address suggestions count metric for this page?
   bool has_logged_address_suggestions_count_;
   // Have we shown Autofill suggestions at least once?
   bool did_show_suggestions_;
   // Has the user manually edited at least one form field among the autofillable
   // ones?
@@ skipping 50 matching lines @@
   FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest,
                            TestTabContentsWithExternalDelegate);
   FRIEND_TEST_ALL_PREFIXES(AutofillMetricsTest,
                            UserHappinessFormLoadAndSubmission);
   FRIEND_TEST_ALL_PREFIXES(AutofillMetricsTest, UserHappinessFormInteraction);
 
   DISALLOW_COPY_AND_ASSIGN(AutofillManager);
 };
 
 #endif  // CHROME_BROWSER_AUTOFILL_AUTOFILL_MANAGER_H_