Pop up requestAutocomplete UI when autofill server hints chrome client that it is in a multipage au…

chrome/renderer/autofill/autofill_agent.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/autofill/autofill_agent.h"
 
 #include "base/bind.h"
 #include "base/message_loop.h"
 #include "base/string_split.h"
 #include "base/string_util.h"
@@ skipping 688 matching lines @@
                       &data_list_labels,
                       &data_list_icons,
                       &data_list_unique_ids);
 
   Send(new AutofillHostMsg_SetDataList(routing_id(),
                                        data_list_values,
                                        data_list_labels,
                                        data_list_icons,
                                        data_list_unique_ids));
 
+  // Additonally fill SSL Status in the formdata before messaging
+  // QueryFormFieldAutofill to browser process.

[Ilya Sherman, 2012/12/13 02:29:23]

This comment is entirely redundant with the code.  Please either remove it or
change to explain *why* the code does what it does; not *what* the code does.

[Raman Kakilate, 2012/12/13 21:34:34]

Done.

+  form.ssl_status = render_view()->GetSSLStatusOfFrame(
+      element.document().frame());
   Send(new AutofillHostMsg_QueryFormFieldAutofill(routing_id(),
                                                   autofill_query_id_,
                                                   form,
                                                   field,
                                                   bounding_box,
                                                   display_warning_if_disabled));
 }
 
 void AutofillAgent::FillAutofillFormData(const WebNode& node,
                                          int unique_id,
@@ skipping 30 matching lines @@
     web_view->hidePopups();
 
   HideHostPopups();
 }
 
 void AutofillAgent::HideHostPopups() {
   Send(new AutofillHostMsg_HideAutofillPopup(routing_id()));
 }
 
 }  // namespace autofill