Pop up requestAutocomplete UI when autofill server hints chrome client that it is in a multipage au…

chrome/browser/autofill/wallet_infobar_delegate.h

-// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef CHROME_BROWSER_AUTOFILL_AUTOFILL_CC_INFOBAR_DELEGATE_H_
-#define CHROME_BROWSER_AUTOFILL_AUTOFILL_CC_INFOBAR_DELEGATE_H_
+#ifndef CHROME_BROWSER_AUTOFILL_WALLET_INFOBAR_DELEGATE_H_
+#define CHROME_BROWSER_AUTOFILL_WALLET_INFOBAR_DELEGATE_H_
 
 #include "base/basictypes.h"
 #include "base/gtest_prod_util.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/string16.h"
 #include "chrome/browser/api/infobars/confirm_infobar_delegate.h"
+#include "chrome/browser/autofill/autofill_manager.h"
 #include "chrome/browser/autofill/autofill_metrics.h"
+#include "chrome/common/form_data.h"
 #include "webkit/glue/window_open_disposition.h"
 
-class CreditCard;
 class PersonalDataManager;
 
 namespace content {
 struct LoadCommittedDetails;
+struct SSLStatus;
 }
 
 // An InfoBar delegate that enables the user to allow or deny storing credit
 // card information gathered from a form submission.
-class AutofillCCInfoBarDelegate : public ConfirmInfoBarDelegate {
+class WalletInfoBarDelegate : public ConfirmInfoBarDelegate {

[Ilya Sherman, 2012/12/13 02:29:23]

This infobar is not specific to Wallet.  The flow should work equally well if
only local data is available.

[Raman Kakilate, 2012/12/13 21:34:34]

This infobar assumes the kind of data it needs from the user, which is tied to
wallet. Extending this feature to also use local autofill data is probably out
of scope of the present project.

[Ilya Sherman, 2012/12/13 23:23:18]

I don't see anything in the data that is tied to Wallet.  The UI this infobar
invokes is already being designed to support both Wallet and local data sources,
so it is actually more work to restrict to only Wallet data; and is a worse user
experience on top of that.  If you are still not convinced that restricting to
just Wallet data is not appropriate, we should probably schedule a meeting to
gain clarity on this point.

[Raman Kakilate, 2013/01/10 00:54:40]

Renamed it to AutofillFlowInfoBarDelegate as discussed offline.

  public:
-  AutofillCCInfoBarDelegate(InfoBarService* infobar_service,
-                            const CreditCard* credit_card,
-                            PersonalDataManager* personal_data,
-                            const AutofillMetrics* metric_logger);
+  WalletInfoBarDelegate(InfoBarService* infobar_service,
+                        PersonalDataManager* personal_data,
+                        AutofillManager* autofill_mgr,
+                        const AutofillMetrics* metric_logger,
+                        const GURL& source_url,
+                        const content::SSLStatus& ssl_status);
 
  private:
-  virtual ~AutofillCCInfoBarDelegate();
+  virtual ~WalletInfoBarDelegate();
 
   void LogUserAction(AutofillMetrics::InfoBarMetric user_action);
 
   // ConfirmInfoBarDelegate:
   virtual bool ShouldExpire(
       const content::LoadCommittedDetails& details) const OVERRIDE;
   virtual void InfoBarDismissed() OVERRIDE;
   virtual gfx::Image* GetIcon() const OVERRIDE;
   virtual Type GetInfoBarType() const OVERRIDE;
   virtual string16 GetMessageText() const OVERRIDE;
   virtual string16 GetButtonLabel(InfoBarButton button) const OVERRIDE;
   virtual bool Accept() OVERRIDE;
   virtual bool Cancel() OVERRIDE;
   virtual string16 GetLinkText() const OVERRIDE;
   virtual bool LinkClicked(WindowOpenDisposition disposition) OVERRIDE;
 
-  // The credit card that should be saved if the user accepts the infobar.
-  scoped_ptr<const CreditCard> credit_card_;
-
   // The personal data manager to which the credit card should be saved.
   // Weak reference.
   PersonalDataManager* personal_data_;

[Ilya Sherman, 2012/12/13 02:29:23]

Why do you need the PDM?

[Raman Kakilate, 2012/12/13 21:34:34]

No I don't yet, removed.

 
   // For logging UMA metrics.
   // Weak reference. Owned by the AutofillManager that initiated this infobar.
   const AutofillMetrics* metric_logger_;
 
+  // To callback AutofillManager's ShowWalletDialog.
+  AutofillManager* autofill_mgr_;

[Ilya Sherman, 2012/12/13 02:29:23]

nit: Please spell out "manager"

[Raman Kakilate, 2012/12/13 21:34:34]

Done.

+
+  // URL of the page which triggered infobar.
+  GURL source_url_;
+
+  // SSL status of the page which triggered infobar.
+  content::SSLStatus ssl_status_;
+
   // Did the user ever explicitly accept or dismiss this infobar?
   bool had_user_interaction_;
 
-  FRIEND_TEST_ALL_PREFIXES(AutofillMetricsTest, CreditCardInfoBar);
-
-  DISALLOW_COPY_AND_ASSIGN(AutofillCCInfoBarDelegate);
+  DISALLOW_COPY_AND_ASSIGN(WalletInfoBarDelegate);
 };
 
-#endif  // CHROME_BROWSER_AUTOFILL_AUTOFILL_CC_INFOBAR_DELEGATE_H_
+#endif  // CHROME_BROWSER_AUTOFILL_WALLET_INFOBAR_DELEGATE_H_