Pop up requestAutocomplete UI when autofill server hints chrome client that it is in a multipage au…

chrome/browser/autofill/autofill_xml_parser.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_AUTOFILL_AUTOFILL_XML_PARSER_H_
 #define CHROME_BROWSER_AUTOFILL_AUTOFILL_XML_PARSER_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 52 matching lines @@
 //
 // Fields are returned in the same order they were sent to the server.
 // autofilltype: The server's guess at what type of field this is.  0 is
 // unknown, other types are documented in chrome/browser/autofill/field_types.h.
 class AutofillQueryXmlParser : public AutofillXmlParser {
  public:
   AutofillQueryXmlParser(std::vector<AutofillFieldType>* field_types,
                          UploadRequired* upload_required,
                          std::string* experiment_id);
 
+  int GetPageNo() { return page_no_; }

[Ilya Sherman, 2012/12/13 02:29:23]

nit: Please spell out "number".  This method should be named "page_number()";
the variable should be named "page_number_"

[Raman Kakilate, 2012/12/13 21:34:34]

Done.

+
+  int GetTotalPages() { return total_pages_; }

[Ilya Sherman, 2012/12/13 02:29:23]

nit: This method should be named total_pages()

[Raman Kakilate, 2012/12/13 21:34:34]

Done.

+
  private:
   // A callback for the beginning of a new <element>, called by Expat.
   // |context| is a parsing context used to resolve element/attribute names.
   // |name| is the name of the element.
   // |attrs| is the list of attributes (names and values) for the element.
   virtual void StartElement(buzz::XmlParseContext* context,
                             const char* name,
                             const char** attrs) OVERRIDE;
 
   // A helper function to retrieve integer values from strings.  Raises an
   // XML parse error if it fails.
   // |context| is the current parsing context.
   // |value| is the string to convert.
   int GetIntValue(buzz::XmlParseContext* context, const char* attribute);
 
   // The parsed field types.
   std::vector<AutofillFieldType>* field_types_;
 
   // A flag indicating whether the client should upload Autofill data when this
   // form is submitted.
   UploadRequired* upload_required_;
 
+  // Page number of present page in multipage autofill flow.

[Ilya Sherman, 2012/12/13 02:29:23]

Why is the XML server responsible for keeping track of which page this is? 
Shouldn't it always be the first page?

[Raman Kakilate, 2012/12/13 21:34:34]

Idea is show autofill_dialog_controller UI on the first page and gather all the
data required for the flow. and on subsequent pages, we should just fill the
page and navigate.

we would have to identify
- start of the flow
- being inside the flow and
- the last step of the flow. 

All of that information can be inferred using page_number_ and total_pages_

[Ilya Sherman, 2012/12/13 23:23:18]

That all makes sense.  What I don't understand is why the server would ever send
down data for any page other than the first.  I'd expect that when the user
navigates to the first page in the flow, the server simply sends down data for
that page as well as all subsequent pages in the flow.  This allows us to avoid
the overhead of making a new connection to the server on each page load.  What
am I missing?

[Raman Kakilate, 2013/01/10 00:54:40]

Server sending down data for all the possible flows at once is an option we
haven't considered much. We could definitely do it as optimization (will involve
changes in both chrome and autofill server).

+  int page_no_;
+
+  // Total number of pages in multipage autofill flow.
+  int total_pages_;
+
   // The server experiment to which this query response belongs.
   // For the default server implementation, this is empty.
   std::string* experiment_id_;
 
   DISALLOW_COPY_AND_ASSIGN(AutofillQueryXmlParser);
 };
 
 // The XML parser for handling Autofill upload responses.  Typical upload
 // responses look like:
 //
@@ skipping 28 matching lines @@
   // True if parsing succeeded.
   bool succeeded_;
 
   double* positive_upload_rate_;
   double* negative_upload_rate_;
 
   DISALLOW_COPY_AND_ASSIGN(AutofillUploadXmlParser);
 };
 
 #endif  // CHROME_BROWSER_AUTOFILL_AUTOFILL_XML_PARSER_H_