Pop up requestAutocomplete UI when autofill server hints chrome client that it is in a multipage au…

chrome/browser/autofill/autofill_xml_parser.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/autofill/autofill_xml_parser.h"
 
 #include <stdlib.h>
 #include <string.h>
 
 #include "base/logging.h"
@@ skipping 15 matching lines @@
                               XML_Error error_code) {
   succeeded_ = false;
 }
 
 AutofillQueryXmlParser::AutofillQueryXmlParser(
     std::vector<AutofillFieldType>* field_types,
     UploadRequired* upload_required,
     std::string* experiment_id)
     : field_types_(field_types),
       upload_required_(upload_required),
+      page_number_(-1), total_pages_(-1),

[ahutter, 2012/12/17 17:35:39]

separate lines.

[Raman Kakilate, 2013/01/10 00:54:40]

Done.

       experiment_id_(experiment_id) {
   DCHECK(upload_required_);
   DCHECK(experiment_id_);
 }
 
 void AutofillQueryXmlParser::StartElement(buzz::XmlParseContext* context,
                                           const char* name,
                                           const char** attrs) {
   buzz::QName qname = context->ResolveQName(name, false);
   const std::string& element = qname.LocalPart();
@@ skipping 36 matching lines @@
     if (attribute_name.compare("autofilltype") == 0) {
       int value = GetIntValue(context, attrs[1]);
       field_type = static_cast<AutofillFieldType>(value);
       if (field_type < 0 || field_type > MAX_VALID_FIELD_TYPE) {
         field_type = NO_SERVER_DATA;
       }
     }
 
     // Record this field type.
     field_types_->push_back(field_type);
+  } else if (element.compare("wallet_data") == 0) {
+    // |attrs| is a NULL-terminated list of (attribute, value) pairs.
+    while (*attrs) {
+      buzz::QName attribute_qname = context->ResolveQName(*attrs, true);
+      ++attrs;
+      const std::string& attribute_name = attribute_qname.LocalPart();
+      if (attribute_name.compare("page_no") == 0) {

[ahutter, 2012/12/17 17:35:39]

Can't you use == instead of compare?

[Raman Kakilate, 2013/01/10 00:54:40]

being consistent with other uses in the file.

+        page_number_ = GetIntValue(context, *attrs);
+      } else if (attribute_name.compare("total_pages") == 0) {
+        total_pages_ = GetIntValue(context, *attrs);
+      }
+      ++attrs;
+    }
   }
 }
 
 int AutofillQueryXmlParser::GetIntValue(buzz::XmlParseContext* context,
                                         const char* attribute) {
   char* attr_end = NULL;
   int value = strtol(attribute, &attr_end, 10);
   if (attr_end != NULL && attr_end == attribute) {
     context->RaiseError(XML_ERROR_SYNTAX);
     return 0;
@@ skipping 33 matching lines @@
 double AutofillUploadXmlParser::GetDoubleValue(buzz::XmlParseContext* context,
                                                const char* attribute) {
   char* attr_end = NULL;
   double value = strtod(attribute, &attr_end);
   if (attr_end != NULL && attr_end == attribute) {
     context->RaiseError(XML_ERROR_SYNTAX);
     return 0.0;
   }
   return value;
 }