Issue 1153893006: Replace setBoxDecoration() with a decoration property.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1153893006: Replace setBoxDecoration() with a decoration property. (Closed)

Created:
5 years, 7 months ago by Hixie

Modified:
5 years, 7 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, gregsimon, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Replace setBoxDecoration() with a decoration property. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/18860b33811b83e9112dee3b95cc347fb26d9a40

Patch Set 1 #

Total comments: 2

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -7 lines)			Patch
	M	sky/examples/raw/simple_render_tree.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	sky/sdk/lib/framework/layout2.dart	View		4 chunks	+8 lines, -5 lines	2 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

abarth-chromium

lgtm https://codereview.chromium.org/1153893006/diff/1/sky/sdk/lib/framework/layout2.dart File sky/sdk/lib/framework/layout2.dart (right): https://codereview.chromium.org/1153893006/diff/1/sky/sdk/lib/framework/layout2.dart#newcode541 sky/sdk/lib/framework/layout2.dart:541: extraneous change? https://codereview.chromium.org/1153893006/diff/1/sky/sdk/lib/framework/layout2.dart#newcode686 sky/sdk/lib/framework/layout2.dart:686: void set padding (EdgeDims ...

5 years, 7 months ago (2015-05-27 16:29:40 UTC) #2

Hixie

5 years, 7 months ago (2015-05-27 16:30:29 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
18860b33811b83e9112dee3b95cc347fb26d9a40 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages