In JsonEncoder, test if map has only string keys, and use toEncodable if not.

sdk/lib/convert/json.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of dart.convert;
 
 /**
  * Error thrown by JSON serialization if an object cannot be serialized.
  *
  * The [unsupportedObject] field holds that object that failed to be serialized.
@@ skipping 675 matching lines @@
       writeStringContent(object);
       writeString('"');
       return true;
     } else if (object is List) {
       _checkCycle(object);
       writeList(object);
       _removeSeen(object);
       return true;
     } else if (object is Map) {
       _checkCycle(object);
-      writeMap(object);
+      // writeMap can fail if keys are not all strings.
+      var success = writeMap(object);
       _removeSeen(object);
-      return true;
+      return success;
     } else {
       return false;
     }
   }
 
   /** Serializes a [List]. */
   void writeList(List list) {
     writeString('[');
     if (list.length > 0) {
       writeObject(list[0]);
       for (int i = 1; i < list.length; i++) {
         writeString(',');
         writeObject(list[i]);
       }
     }
     writeString(']');
   }
 
   /** Serializes a [Map]. */
-  void writeMap(Map<String, Object> map) {
+  bool writeMap(Map<String, Object> map) {
+    if (map.isEmpty) {
+      writeString("{}");
+      return true;
+    }
+    List keyValueList = new List(map.length * 2);
+    int i = 0;
+    bool allStringKeys = true;
+    map.forEach((key, value) {
+      if (key is! String) {
+        allStringKeys = false;
+      }
+      keyValueList[i++] = key;
+      keyValueList[i++] = value;
+    });
+    if (!allStringKeys) return false;
     writeString('{');
     String separator = '"';
-    map.forEach((String key, value) {
+    for (int i = 0; i < keyValueList.length; i += 2) {
       writeString(separator);
       separator = ',"';
-      writeStringContent(key);
+      writeStringContent(keyValueList[i]);
       writeString('":');
-      writeObject(value);
-    });
+      writeObject(keyValueList[i + 1]);
+    }
     writeString('}');
+    return true;
   }
 }
 
 /**
  * A modification of [_JsonStringifier] which indents the contents of [List] and
  * [Map] objects using the specified indent value.
  *
  * Subclasses should implement [writeIndentation].
  */
 abstract class _JsonPrettyPrintMixin implements _JsonStringifier {
@@ skipping 17 matching lines @@
         writeIndentation(_indentLevel);
         writeObject(list[i]);
       }
       writeString('\n');
       _indentLevel--;
       writeIndentation(_indentLevel);
       writeString(']');
     }
   }
 
-  void writeMap(Map map) {
+  bool writeMap(Map map) {
     if (map.isEmpty) {
-      writeString('{}');
-    } else {
-      writeString('{\n');
-      _indentLevel++;
-      bool first = true;
-      map.forEach((String key, Object value) {
-        if (!first) {
-          writeString(",\n");
-        }
-        writeIndentation(_indentLevel);
-        writeString('"');
-        writeStringContent(key);
-        writeString('": ');
-        writeObject(value);
-        first = false;
-      });
-      writeString('\n');
-      _indentLevel--;
+      writeString("{}");
+      return true;
+    }
+    List keyValueList = new List(map.length * 2);
+    int i = 0;
+    bool allStringKeys = true;
+    map.forEach((key, value) {
+      if (key is! String) {
+        allStringKeys = false;
+      }
+      keyValueList[i++] = key;
+      keyValueList[i++] = value;
+    });
+    if (!allStringKeys) return false;
+    writeString('{\n');
+    _indentLevel++;
+    String separator = "";
+    for (int i = 0; i < keyValueList.length; i += 2) {
+      writeString(separator);
+      separator = ",\n";
       writeIndentation(_indentLevel);
-      writeString('}');
+      writeString('"');
+      writeStringContent(keyValueList[i]);
+      writeString('": ');
+      writeObject(keyValueList[i + 1]);
     }
+    writeString('\n');
+    _indentLevel--;
+    writeIndentation(_indentLevel);
+    writeString('}');
+    return true;
   }
 }
 
 /**
  * A specialziation of [_JsonStringifier] that writes its JSON to a string.
  */
 class _JsonStringStringifier extends _JsonStringifier {
   final StringSink _sink;
 
   _JsonStringStringifier(this._sink, _toEncodable) : super(_toEncodable);
@@ skipping 230 matching lines @@
         buffer.setRange(index, end, indent);
         index = end;
       } else {
         for (int i = 0; i < indentLength; i++) {
           writeByte(indent[i]);
         }
       }
     }
   }
 }