Issue 1153873005: Dismiss browser plugin modal dialogs when the embedder needs to.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1153873005: Dismiss browser plugin modal dialogs when the embedder needs to. (Closed)

Created:
5 years, 6 months ago by Charlie Reis

Modified:
5 years, 6 months ago

Reviewers:
sky, nasko

CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2403

Target Ref:
refs/pending/branch-heads/2403

Project:
chromium

Visibility:
Public.

More Reviews

Description

Dismiss browser plugin modal dialogs when the embedder needs to. Test from wjmaclean@. PDF simply shows an alert dialog using script. TBR=nasko,sky BUG=482380 TEST=See bug for repro steps. NOTRY=true NOPRESUBMIT=true Review URL: https://codereview.chromium.org/1150843002 Cr-Commit-Position: refs/heads/master@{#331584} (cherry picked from commit 89a0f782193755ad7a0b93c58dbcc1b96528405f)

Patch Set 1 #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+65 lines, -6 lines)			Patch
M	chrome/browser/ui/browser_browsertest.cc	View	1 chunk	+26 lines, -0 lines	0 comments	Download
A	chrome/test/data/alert_dialog.pdf	View	Binary file		0 comments	Download
M	content/browser/browser_plugin/browser_plugin_embedder.h	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	content/browser/browser_plugin/browser_plugin_embedder.cc	View	1 chunk	+14 lines, -0 lines	0 comments	Download
M	content/browser/web_contents/web_contents_impl.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	content/browser/web_contents/web_contents_impl.cc	View	5 chunks	+15 lines, -6 lines	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1153873005/1

5 years, 6 months ago (2015-06-01 23:36:27 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages