LayoutTests/fast/selectors/query-update-distribution.html - Issue 1153873004: Handle ::content and :host-context correctly in SelectorQuery.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/selectors/query-update-distribution.html

Issue 1153873004: Handle ::content and :host-context correctly in SelectorQuery. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: No really, the right patch. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « LayoutTests/fast/dom/shadow/update-distribution-for-matches-expected.txt ('k') | LayoutTests/fast/selectors/query-update-distribution-expected.txt » ('j') | Source/core/dom/SelectorQuery.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../resources/js-test.js"></script>

	3

	4 <div id="target">

	5 <div id="a">

	6 <div id="b"></div>

	7 </div>

	8 </div>

	9

	10 <script>

	11 description("Should update distribution when needed for querySelector and relate d methods.");

	12

	13 var target = document.getElementById("target");

	14 var a = document.getElementById("a");

	15

	16 var targetRoot = target.createShadowRoot();

	17 targetRoot.innerHTML = "<div id=c><content></content></div>";

	18 var c = targetRoot.getElementById("c");

	19

	20 var aRoot = a.createShadowRoot();

	21 aRoot.innerHTML = "<div id=d></div>";

	22 var d = aRoot.getElementById("d");

	23

	24 shouldBe("aRoot.querySelector(':host-context(#c) #d')", "d");

	25 // This does actually match #a, but it's in the wrong scope.

	26 shouldBeNull("targetRoot.querySelector('::content #a')");

	27 shouldBeFalse("a.matches('::content #a')");

	28 shouldBeTrue("d.matches(':host-context(#target) #d')");

	29 shouldBeTrue("d.matches(':host-context(#c) #d')");

	30 shouldBeNull("b.closest('::content #a')");
	kochi 2015/05/25 11:07:04 Hopefully, we have 3 separate cases, 1. createSha Hopefully, we have 3 separate cases, 1. createShadowRoot(), then immediately .querySelector() 2. createShadowRoot(), then immediately .matches() 3. createShadowRoot(), then immediately .closest() to check if all added .updateDistribution() calls in SelectorDataList::execute(), ::matches(), ::closest() independently. IIUC, In this test, line 24 calls querySelector(), then updateDistribution() is done, and in the following lines updateDistribution() will never be called - in that case, createShadowRoot() -> matches() -> updateDistribution() and createShadowRoot() -> closest() -> updateDistribution() paths are not exercised by this layout test. esprehn 2015/05/25 20:52:26 Updated the test to dirty between each test and ad Updated the test to dirty between each test and added a few more cases.
	31 </script>

OLD	NEW