Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Unified Diff: chrome/browser/media/midi_permission_context.cc

Issue 1153873003: Add way for PermissionContext to be automatically restricted to secure origins. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@midi_permission_sysex
Patch Set: typo Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/midi_permission_context.cc
diff --git a/chrome/browser/media/midi_permission_context.cc b/chrome/browser/media/midi_permission_context.cc
index 95cffbb0fa7a99d0e5f27f806492e75380598baf..940dd21141abbbb40a1c04197e06a4cdc742f7a3 100644
--- a/chrome/browser/media/midi_permission_context.cc
+++ b/chrome/browser/media/midi_permission_context.cc
@@ -7,7 +7,6 @@
#include "chrome/browser/content_settings/tab_specific_content_settings.h"
#include "components/content_settings/core/common/permission_request_id.h"
#include "content/public/browser/child_process_security_policy.h"
-#include "content/public/common/origin_util.h"
#include "url/gurl.h"
MidiPermissionContext::MidiPermissionContext(Profile* profile)
@@ -17,37 +16,6 @@ MidiPermissionContext::MidiPermissionContext(Profile* profile)
MidiPermissionContext::~MidiPermissionContext() {
}
-ContentSetting MidiPermissionContext::GetPermissionStatus(
- const GURL& requesting_origin,
- const GURL& embedding_origin) const {
- if (requesting_origin.is_valid() &&
- !content::IsOriginSecure(requesting_origin)) {
- return CONTENT_SETTING_BLOCK;
- }
-
- return PermissionContextBase::GetPermissionStatus(requesting_origin,
- embedding_origin);
-}
-
-void MidiPermissionContext::DecidePermission(
- content::WebContents* web_contents,
- const PermissionRequestID& id,
- const GURL& requesting_origin,
- const GURL& embedding_origin,
- bool user_gesture,
- const BrowserPermissionCallback& callback) {
- if (requesting_origin.is_valid() &&
- !content::IsOriginSecure(requesting_origin)) {
- NotifyPermissionSet(id, requesting_origin, embedding_origin, callback,
- false /* persist */, CONTENT_SETTING_BLOCK);
- return;
- }
-
- PermissionContextBase::DecidePermission(
- web_contents, id, requesting_origin,
- embedding_origin, user_gesture, callback);
-}
-
void MidiPermissionContext::UpdateTabContext(const PermissionRequestID& id,
const GURL& requesting_frame,
bool allowed) {
@@ -66,3 +34,7 @@ void MidiPermissionContext::UpdateTabContext(const PermissionRequestID& id,
content_settings->OnMidiSysExAccessBlocked(requesting_frame);
}
}
+
+bool MidiPermissionContext::IsRestrictedToSecureOrigins() const {
+ return true;
+}
« no previous file with comments | « chrome/browser/media/midi_permission_context.h ('k') | chrome/browser/media/protected_media_identifier_permission_context.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698