chrome/browser/push_messaging/push_messaging_permission_context.cc - Issue 1153873003: Add way for PermissionContext to be automatically restricted to secure origins.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/push_messaging/push_messaging_permission_context.cc

Issue 1153873003: Add way for PermissionContext to be automatically restricted to secure origins. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@midi_permission_sysex

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/notifications/desktop_notification_service.cc ('K') | « chrome/browser/push_messaging/push_messaging_permission_context.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/push_messaging/push_messaging_permission_context.cc

diff --git a/chrome/browser/push_messaging/push_messaging_permission_context.cc b/chrome/browser/push_messaging/push_messaging_permission_context.cc

index 885589e1934a05d35bc4676d92265896a813dc54..f37a363885678e21b5b2bf95b27dd61956da3afb 100644

--- a/chrome/browser/push_messaging/push_messaging_permission_context.cc

+++ b/chrome/browser/push_messaging/push_messaging_permission_context.cc

@@ -102,6 +102,10 @@ void PushMessagingPermissionContext::DecidePermission(

#endif

}

+bool PushMessagingPermissionContext::RestrictToSecureOrigins() const {

+ return true;

ddorwin 2015/05/26 17:31:31 This is a change in behavior (like MIDI in the oth

mlamouri (slow - plz ping) 2015/05/29 14:35:15 Correct.

void PushMessagingPermissionContext::DecidePushPermission(

const PermissionRequestID& id,

const GURL& requesting_origin,

« chrome/browser/notifications/desktop_notification_service.cc ('K') | « chrome/browser/push_messaging/push_messaging_permission_context.h ('k') | no next file » | no next file with comments »