Issue 1153803005: Revert of Fix LCD coverage regression in GrPorterDuffXPFactory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1153803005: Revert of Fix LCD coverage regression in GrPorterDuffXPFactory (Closed)

Created:
5 years, 7 months ago by bungeman-skia

Modified:
5 years, 7 months ago

Reviewers:
bsalomon, egdaniel, Chris Dalton

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Revert of Fix LCD coverage regression in GrPorterDuffXPFactory (patchset #3 id:40001 of https://codereview.chromium.org/1149883004/) Reason for revert: Reverting this fix to revert https://codereview.chromium.org/1124373002 Original issue's description: > Fix LCD coverage regression in GrPorterDuffXPFactory > > Fixes GrPorterDuffXPFactory to not use the blend table when getting > info about the LCD coverage XP. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/3e2d59ef36e1b9a63e524cf1b27d5f7bcfb5ff0b TBR=bsalomon@google.com,egdaniel@google.com,cdalton@nvidia.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/c319c80d09c6e9c681041f9e9db7b6bcbae542cc

Created: 5 years, 7 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -70 lines)			Patch
	M	src/gpu/effects/GrPorterDuffXferProcessor.cpp	View		2 chunks	+7 lines, -14 lines	0 comments	Download
	M	tests/GrPorterDuffTest.cpp	View		10 chunks	+0 lines, -56 lines	0 comments	Download

Total messages: 3 (0 generated)

bungeman-skia

Created Revert of Fix LCD coverage regression in GrPorterDuffXPFactory

5 years, 7 months ago (2015-05-23 00:54:24 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1153803005/1

5 years, 7 months ago (2015-05-23 00:54:38 UTC) #2

commit-bot: I haz the power

5 years, 7 months ago (2015-05-23 00:54:47 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/c319c80d09c6e9c681041f9e9db7b6bcbae542cc