Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Issue 1153803002: gn: Add a newline to fix a bulleted list in README.md. (Closed)

Created:
5 years, 7 months ago by jbroman
Modified:
5 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gn: Add a newline to fix a bulleted list in README.md. Currently the bulleted list in the "What does 'done' mean?" section isn't rendered (instead, it is shown as one paragraph with asterisks in the middle). Adding a newline should fix this. See https://chromium.googlesource.com/chromium/src/tools/gn/+/441de2f Committed: https://crrev.com/92acc5eca80b1cbd6fcf18a81795c5b74f9d3f06 Cr-Commit-Position: refs/heads/master@{#331229}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M tools/gn/README.md View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
jbroman
Trivial, but annoyed me when I was reading docs.
5 years, 7 months ago (2015-05-22 15:31:30 UTC) #2
brettw
lgtm
5 years, 7 months ago (2015-05-22 20:40:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1153803002/1
5 years, 7 months ago (2015-05-23 05:04:18 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-23 05:14:15 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-23 05:14:58 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/92acc5eca80b1cbd6fcf18a81795c5b74f9d3f06
Cr-Commit-Position: refs/heads/master@{#331229}

Powered by Google App Engine
This is Rietveld 408576698