Issue 11538010: Fixed compilation error on Win64.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11538010: Fixed compilation error on Win64. (Closed)

Created:
8 years ago by Hannes Payer (out of office)

Modified:
8 years ago

Reviewers:
danno, Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fixed compilation error on Win64. BUG= Committed: https://code.google.com/p/v8/source/detail?r=13199

Patch Set 2 : #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	src/spaces.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM (with a nit). https://codereview.chromium.org/11538010/diff/1/src/spaces.cc File src/spaces.cc (right): https://codereview.chromium.org/11538010/diff/1/src/spaces.cc#newcode1940 src/spaces.cc:1940: intptr_t sum = 0; Can ...

8 years ago (2012-12-11 18:55:43 UTC) #2

Hannes Payer (out of office)

8 years ago (2012-12-11 20:19:02 UTC) #3

https://codereview.chromium.org/11538010/diff/1/src/spaces.cc
File src/spaces.cc (right):

https://codereview.chromium.org/11538010/diff/1/src/spaces.cc#newcode1940
src/spaces.cc:1940: intptr_t sum = 0;
On 2012/12/11 18:55:43, Michael Starzinger wrote:
> Can we also turn this "sum" accumulator into "int".

Done.

Expand Messages | Collapse Messages

Issue 11538010: Fixed compilation error on Win64. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages