Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: sdk/lib/isolate/timer.dart

Issue 11538007: Clean up the timer source in the isolate library to be less VM specific. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/isolate/timer.dart
===================================================================
--- sdk/lib/isolate/timer.dart (revision 15985)
+++ sdk/lib/isolate/timer.dart (working copy)
@@ -7,43 +7,17 @@
* Creates a new timer. The [callback] callback is invoked after
* [milliSeconds] milliseconds.
*/
- factory Timer(int milliSeconds, void callback(Timer timer)) {
- if (_TimerFactory._factory == null) {
- throw new UnsupportedError("Timer interface not supported.");
- }
- return _TimerFactory._factory(milliSeconds, callback, false);
- }
+ external factory Timer(int milliSeconds, void callback(Timer timer));
/**
* Creates a new repeating timer. The [callback] is invoked every
* [milliSeconds] millisecond until cancelled.
*/
- factory Timer.repeating(int milliSeconds, void callback(Timer timer)) {
- if (_TimerFactory._factory == null) {
- throw new UnsupportedError("Timer interface not supported.");
- }
- return _TimerFactory._factory(milliSeconds, callback, true);
- }
+ external factory Timer.repeating(int milliSeconds,
+ void callback(Timer timer));
/**
* Cancels the timer.
*/
void cancel();
}
-
-// TODO(ajohnsen): Patch timer once we have support for patching named
-// factory constructors in the VM.
-
-typedef Timer _TimerFactoryClosure(int milliSeconds,
- void callback(Timer timer),
- bool repeating);
-
-class _TimerFactory {
- static _TimerFactoryClosure _factory;
-}
-
-// TODO(ahe): Warning: this is NOT called by Dartium. Instead, it sets
-// [_TimerFactory._factory] directly.
-void _setTimerFactoryClosure(_TimerFactoryClosure closure) {
- _TimerFactory._factory = closure;
-}

Powered by Google App Engine
This is Rietveld 408576698