Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1430)

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 1153793003: Add user_gesture param to WebContentsImpl::Activate Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update callers Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/web_contents/web_contents_impl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/web_contents/web_contents_impl.cc
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
index 95352e39037f7de388debb2bc04e92fd0232a898..6603fa0c3c9d2c0916e0bfdf9df4f0ed2c0b044c 100644
--- a/content/browser/web_contents/web_contents_impl.cc
+++ b/content/browser/web_contents/web_contents_impl.cc
@@ -1326,7 +1326,7 @@ WebContentsImpl::GetRenderWidgetHostViewsInTree() {
return set;
}
-void WebContentsImpl::Activate() {
+void WebContentsImpl::Activate(bool user_gesture) {
if (delegate_)
delegate_->ActivateContents(this);
}
@@ -3177,7 +3177,8 @@ void WebContentsImpl::NotifyBeforeFormRepostWarningShow() {
}
void WebContentsImpl::ActivateAndShowRepostFormWarningDialog() {
- Activate();
+ // TODO(johnme): Can we sometimes be certain this was for a user gesture?
+ Activate(false /* user_gesture */);
if (delegate_)
delegate_->ShowRepostFormWarningDialog(this);
}
« no previous file with comments | « content/browser/web_contents/web_contents_impl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698