Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Unified Diff: content/browser/renderer_host/render_view_host_impl.cc

Issue 1153793003: Add user_gesture param to WebContentsImpl::Activate Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update callers Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_view_host_impl.cc
diff --git a/content/browser/renderer_host/render_view_host_impl.cc b/content/browser/renderer_host/render_view_host_impl.cc
index a6f7a4567da0a113b7945b2b8058d651d49377af..bfa137d4fef13f67b74f370fbac5af5548489e32 100644
--- a/content/browser/renderer_host/render_view_host_impl.cc
+++ b/content/browser/renderer_host/render_view_host_impl.cc
@@ -1236,7 +1236,8 @@ blink::WebDisplayMode RenderViewHostImpl::GetDisplayMode() const {
void RenderViewHostImpl::OnFocus() {
// Note: We allow focus and blur from swapped out RenderViewHosts, even when
// the active RenderViewHost is in a different BrowsingInstance (e.g., WebUI).
- delegate_->Activate();
+ // TODO(johnme): Can we sometimes be certain this was for a user gesture?
+ delegate_->Activate(false /* user_gesture */);
}
void RenderViewHostImpl::OnBlur() {

Powered by Google App Engine
This is Rietveld 408576698