Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1153763008: Sync SVG interfaces with the specs (Closed)

Created:
5 years, 7 months ago by philipj_slow
Modified:
5 years, 7 months ago
Reviewers:
pdr., fs
CC:
darktears, arv+blink, blink-reviews, blink-reviews-animation_chromium.org, Inactive, krit, Eric Willigers, f(malita), fs, gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans, vivekg_samsung, vivekg
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Sync SVG interfaces with the specs Add use counters for some things that are gone from the specs. BUG=460722 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195970

Patch Set 1 #

Patch Set 2 : moar #

Patch Set 3 : moar #

Patch Set 4 : all done #

Total comments: 14

Patch Set 5 : Address feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+318 lines, -85 lines) Patch
M Source/core/frame/UseCounter.h View 1 2 3 4 1 chunk +11 lines, -0 lines 0 comments Download
M Source/core/svg/SVGAElement.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGAngle.idl View 1 2 3 4 2 chunks +4 lines, -3 lines 0 comments Download
M Source/core/svg/SVGAnimateElement.idl View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/svg/SVGAnimateMotionElement.idl View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/svg/SVGAnimateTransformElement.idl View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/svg/SVGAnimatedAngle.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGAnimatedBoolean.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGAnimatedEnumeration.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGAnimatedInteger.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGAnimatedLength.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGAnimatedLengthList.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGAnimatedNumber.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGAnimatedNumberList.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGAnimatedPreserveAspectRatio.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGAnimatedRect.idl View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/svg/SVGAnimatedString.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGAnimatedTransformList.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGCircleElement.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGClipPathElement.idl View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/svg/SVGComponentTransferFunctionElement.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGCursorElement.idl View 2 chunks +4 lines, -2 lines 0 comments Download
M Source/core/svg/SVGDefsElement.idl View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/svg/SVGDescElement.idl View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/svg/SVGDiscardElement.idl View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/svg/SVGDocument.idl View 1 chunk +3 lines, -2 lines 0 comments Download
M Source/core/svg/SVGElement.idl View 1 chunk +5 lines, -4 lines 0 comments Download
M Source/core/svg/SVGEllipseElement.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGFEConvolveMatrixElement.idl View 1 2 3 2 chunks +5 lines, -2 lines 0 comments Download
M Source/core/svg/SVGFEDistantLightElement.idl View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/svg/SVGFEFuncAElement.idl View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/svg/SVGFEFuncBElement.idl View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/svg/SVGFEFuncGElement.idl View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/svg/SVGFEFuncRElement.idl View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/svg/SVGFEMergeNodeElement.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGFEPointLightElement.idl View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGFESpecularLightingElement.idl View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/svg/SVGFESpotLightElement.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGFilterElement.idl View 2 chunks +8 lines, -4 lines 0 comments Download
M Source/core/svg/SVGForeignObjectElement.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGGElement.idl View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/svg/SVGGeometryElement.idl View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/svg/SVGGradientElement.idl View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/svg/SVGImageElement.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGLength.idl View 1 2 3 4 2 chunks +4 lines, -2 lines 0 comments Download
M Source/core/svg/SVGLengthList.idl View 1 2 chunks +7 lines, -5 lines 0 comments Download
M Source/core/svg/SVGLineElement.idl View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGLinearGradientElement.idl View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGMPathElement.idl View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/svg/SVGMarkerElement.idl View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/svg/SVGMaskElement.idl View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/svg/SVGMatrix.idl View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
M Source/core/svg/SVGMetadataElement.idl View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/svg/SVGNumber.idl View 1 2 3 4 2 chunks +3 lines, -1 line 0 comments Download
M Source/core/svg/SVGNumberList.idl View 1 2 chunks +7 lines, -5 lines 0 comments Download
M Source/core/svg/SVGPathElement.idl View 1 2 chunks +10 lines, -1 line 0 comments Download
M Source/core/svg/SVGPathSeg.idl View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGPathSegArcAbs.idl View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGPathSegArcRel.idl View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGPathSegClosePath.idl View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGPathSegCurvetoCubicAbs.idl View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGPathSegCurvetoCubicRel.idl View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGPathSegCurvetoCubicSmoothAbs.idl View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGPathSegCurvetoCubicSmoothRel.idl View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGPathSegCurvetoQuadraticAbs.idl View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGPathSegCurvetoQuadraticRel.idl View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGPathSegCurvetoQuadraticSmoothAbs.idl View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGPathSegCurvetoQuadraticSmoothRel.idl View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGPathSegLinetoAbs.idl View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGPathSegLinetoHorizontalAbs.idl View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGPathSegLinetoHorizontalRel.idl View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGPathSegLinetoRel.idl View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGPathSegLinetoVerticalAbs.idl View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGPathSegLinetoVerticalRel.idl View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGPathSegList.idl View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M Source/core/svg/SVGPathSegMovetoAbs.idl View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGPathSegMovetoRel.idl View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGPatternElement.idl View 1 2 3 2 chunks +5 lines, -2 lines 0 comments Download
M Source/core/svg/SVGPoint.idl View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/svg/SVGPointList.idl View 1 2 3 2 chunks +8 lines, -5 lines 0 comments Download
M Source/core/svg/SVGPolygonElement.idl View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/svg/SVGPolylineElement.idl View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/svg/SVGPreserveAspectRatio.idl View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/svg/SVGRadialGradientElement.idl View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGRect.idl View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/svg/SVGRectElement.idl View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGRenderingIntent.idl View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/svg/SVGSVGElement.idl View 2 chunks +3 lines, -2 lines 0 comments Download
M Source/core/svg/SVGScriptElement.idl View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGSetElement.idl View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/svg/SVGStopElement.idl View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGStringList.idl View 1 2 3 2 chunks +6 lines, -4 lines 0 comments Download
M Source/core/svg/SVGStyleElement.idl View 1 2 3 4 1 chunk +10 lines, -4 lines 0 comments Download
M Source/core/svg/SVGSwitchElement.idl View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGTSpanElement.idl View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/svg/SVGTests.idl View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M Source/core/svg/SVGTextContentElement.idl View 1 2 3 2 chunks +9 lines, -6 lines 0 comments Download
M Source/core/svg/SVGTextElement.idl View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/svg/SVGTextPathElement.idl View 1 2 3 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/svg/SVGTextPositioningElement.idl View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGTitleElement.idl View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/svg/SVGTransform.idl View 1 2 3 4 2 chunks +4 lines, -0 lines 0 comments Download
M Source/core/svg/SVGTransformList.idl View 1 2 2 chunks +9 lines, -8 lines 0 comments Download
M Source/core/svg/SVGUnitTypes.idl View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/svg/SVGUseElement.idl View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGZoomAndPan.idl View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGZoomEvent.idl View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
philipj_slow
PTAL
5 years, 7 months ago (2015-05-26 21:09:37 UTC) #2
pdr.
LGTM I'm unsure how the SVGPoint->DOMPoint change will go, as there is some pushback from ...
5 years, 7 months ago (2015-05-27 03:55:42 UTC) #3
fs
https://codereview.chromium.org/1153763008/diff/60001/Source/core/svg/SVGAngle.idl File Source/core/svg/SVGAngle.idl (right): https://codereview.chromium.org/1153763008/diff/60001/Source/core/svg/SVGAngle.idl#newcode25 Source/core/svg/SVGAngle.idl:25: // TODO(philipj): SVGAngle should have constructors. Note: This is ...
5 years, 7 months ago (2015-05-27 09:12:57 UTC) #5
philipj_slow
Address feedback
5 years, 7 months ago (2015-05-27 09:25:24 UTC) #6
philipj_slow
https://codereview.chromium.org/1153763008/diff/60001/Source/core/svg/SVGAngle.idl File Source/core/svg/SVGAngle.idl (right): https://codereview.chromium.org/1153763008/diff/60001/Source/core/svg/SVGAngle.idl#newcode25 Source/core/svg/SVGAngle.idl:25: // TODO(philipj): SVGAngle should have constructors. On 2015/05/27 09:12:56, ...
5 years, 7 months ago (2015-05-27 09:27:30 UTC) #7
philipj_slow
On 2015/05/27 03:55:42, pdr wrote: > LGTM > > I'm unsure how the SVGPoint->DOMPoint change ...
5 years, 7 months ago (2015-05-27 09:37:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1153763008/80001
5 years, 7 months ago (2015-05-27 09:40:58 UTC) #11
commit-bot: I haz the power
5 years, 7 months ago (2015-05-27 11:19:16 UTC) #12
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195970

Powered by Google App Engine
This is Rietveld 408576698