Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1078)

Issue 1153763003: Idle old generation limit is used when allocation rate is low. (Closed)

Created:
5 years, 7 months ago by Hannes Payer (out of office)
Modified:
5 years, 7 months ago
Reviewers:
ulan
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Idle old generation limit is used when allocation rate is low. BUG= Committed: https://crrev.com/953bf90bcbce3b5e8780ea306f3f2cc7dcc7ddf3 Cr-Commit-Position: refs/heads/master@{#28593}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -16 lines) Patch
M src/heap/heap.h View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/heap.cc View 1 2 4 chunks +11 lines, -15 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
Hannes Payer (out of office)
This simplifies the code, but the idle limit may get removed soon.
5 years, 7 months ago (2015-05-22 11:57:10 UTC) #2
ulan
lgtm! https://codereview.chromium.org/1153763003/diff/1/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/1153763003/diff/1/src/heap/heap.cc#newcode4641 src/heap/heap.cc:4641: // TODO(ulan): Start incremental marking only for large ...
5 years, 7 months ago (2015-05-22 12:04:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1153763003/20001
5 years, 7 months ago (2015-05-22 12:08:45 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_mac_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/6077)
5 years, 7 months ago (2015-05-22 12:13:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1153763003/60001
5 years, 7 months ago (2015-05-22 12:19:14 UTC) #11
Hannes Payer (out of office)
https://codereview.chromium.org/1153763003/diff/1/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/1153763003/diff/1/src/heap/heap.cc#newcode4641 src/heap/heap.cc:4641: // TODO(ulan): Start incremental marking only for large heaps. ...
5 years, 7 months ago (2015-05-22 12:19:46 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: v8_mac_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/6079)
5 years, 7 months ago (2015-05-22 12:23:24 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1153763003/60001
5 years, 7 months ago (2015-05-22 12:37:57 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 7 months ago (2015-05-22 13:10:25 UTC) #17
commit-bot: I haz the power
5 years, 7 months ago (2015-05-22 13:10:40 UTC) #18
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/953bf90bcbce3b5e8780ea306f3f2cc7dcc7ddf3
Cr-Commit-Position: refs/heads/master@{#28593}

Powered by Google App Engine
This is Rietveld 408576698